MIRRORS/layerindex-web
1
0
Fork 0
mirror of git://git.yoctoproject.org/layerindex-web.git synced 2025-07-19 20:59:01 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

utils: fix missing dependency logic in _add_dependency()

Browse Source 
* If a missing dependency is not required, show a warning instead of an
  error
* If logger isn't specified we still need to skip to the next item, so
  move the continue statement out of the conditional block. (In practice
  I don't think this function is currently called anywhere in the code
  without a logger specified, but let's fix it anyway).

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
This commit is contained in:
Paul Eggleton 2018-07-03 09:55:22 +12:00
parent 44a500e121
commit 2f02ddf16d
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
layerindex/utils.py
View File

@ -140,8 +140,11 @@ def _add_dependency(var, name, layerbranch, config_data, logger=None, required=T
# No layer found. # No layer found.
if not dep_layer: if not dep_layer:
if logger: if logger:
logger.error('Cannot resolve %s %s (version %s) for %s' % (name, dep, ver_str, layer_name)) if required:
continue logger.error('Cannot resolve %s %s (version %s) for %s' % (name, dep, ver_str, layer_name))
else:
logger.warning('Cannot resolve %s %s (version %s) for %s' % (name, dep, ver_str, layer_name))
continue
# Preparing to remove obsolete ones # Preparing to remove obsolete ones
if need_remove: if need_remove: