From 5440e10e62aa3a4356d89843581b26dff83c7c67 Mon Sep 17 00:00:00 2001 From: Belen Barros Pena Date: Thu, 13 Aug 2015 14:25:36 +0100 Subject: [PATCH] rrs: avoid too many columns in the recipes table MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Currently, when you select 'Can't be updated' in the upstream status filter, the resulting table will add the 'No update reason' column to the default column set. Although this is probably useful information to see in the table itself, it results in too many columns, and a rather unpleasant layout change. This patch hides the 'Summary' column whenever you select 'Can't be updated' in the upstream status filter, effectively replacing the 'Summary' with the 'No update reason' column, which is probably more relevant in this context. Now you have less columns distracting you, and a slightly less jumpy layout change. A designer would have come up with this solution in the first place. Sadly, she was never asked. Signed-off-by: Belen Barros Pena Signed-off-by: Aníbal Limón --- templates/rrs/recipes.html | 2 ++ 1 file changed, 2 insertions(+) diff --git a/templates/rrs/recipes.html b/templates/rrs/recipes.html index 3ac73d2..8927b2f 100644 --- a/templates/rrs/recipes.html +++ b/templates/rrs/recipes.html @@ -218,8 +218,10 @@ $(document).ready(function() { function applyFilters() { if (upstreamStatus == 'Can\'t be updated') { $('.no_update_reason_column').show() + $('.summary_column').hide() } else { $('.no_update_reason_column').hide() + $('.summary_column').show() } if (upstreamStatus == 'All') {