From 7259ed2393a6d2daf8bc658fa0d3a87e6fb14437 Mon Sep 17 00:00:00 2001 From: Belen Barros Pena Date: Thu, 3 Dec 2015 14:26:15 +0000 Subject: [PATCH] Show the 'Upstream version' column only when relevant Currently the recipes table always shows the 'Upstream version' column. However, for recipes up-to-date, this column is irrelevant, since for such recipes 'version' always equals 'upstream version'. Since the vast majority of the recipes are up-to-date, when you are showing all the recipes the 'upstream version' column is also pretty useless. The column is only really relevant when you are looking at recipes with status 'not updated' or 'can't be updated'. I would have thought there would be nothing to show in the 'Upstream version' column for recipes with status 'Unknown', but it turns out some of those do have an upstream version value, that I thought might be useful to the maintainer somehow. So, this patch hides the 'Upstream version' column whenever you are looking at all the recipes or up-to-date recipes; and shows it when you select any of the other recipe statuses Signed-off-by: Belen Barros Pena --- templates/rrs/recipes.html | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/templates/rrs/recipes.html b/templates/rrs/recipes.html index be2a3a5..96a3bbc 100644 --- a/templates/rrs/recipes.html +++ b/templates/rrs/recipes.html @@ -234,6 +234,12 @@ $(document).ready(function() { $('.summary_column').show() } + if (upstreamStatus == 'Up-to-date' || upstreamStatus == 'All') { + $('.upstream_version_column').hide(); + } else { + $('.upstream_version_column').show(); + } + if (upstreamStatus == 'All') { upstreamStatusFilter = '' } else {