From b940e7c431a96de9486c561c6f97574cc16d7a2f Mon Sep 17 00:00:00 2001 From: Paul Eggleton Date: Tue, 6 Nov 2018 16:29:57 +1300 Subject: [PATCH] Use prop() instead of attr() to set checked property Using attr('checked') is not reliable, the jQuery documentation recommends using prop() with jQuery 1.6 or later and it definitely works more reliably in my testing. Signed-off-by: Paul Eggleton --- templates/layerindex/classicrecipes.html | 14 +++++++------- templates/layerindex/duplicates.html | 8 ++++---- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/templates/layerindex/classicrecipes.html b/templates/layerindex/classicrecipes.html index c4b41c3..b7d961d 100644 --- a/templates/layerindex/classicrecipes.html +++ b/templates/layerindex/classicrecipes.html @@ -341,10 +341,10 @@ } } select_layer_checkboxes = function() { - $('.filterlayercheckbox').attr('checked', false); + $('.filterlayercheckbox').prop('checked', false); selectedlayers = $('#id_selectedlayers').val().split(','); for(i in selectedlayers) { - $('#id_layercheckbox_' + selectedlayers[i]).attr('checked', true); + $('#id_layercheckbox_' + selectedlayers[i]).prop('checked', true); } } setup_layer_list = function() { @@ -372,10 +372,10 @@ } } select_excludeclass_checkboxes = function() { - $('.filterclasscheckbox').attr('checked', false); + $('.filterclasscheckbox').prop('checked', false); excludeclasses = $('#id_excludeclasses').val().split(','); for(i in excludeclasses) { - $('#id_classcheckbox_' + excludeclasses[i]).attr('checked', true); + $('#id_classcheckbox_' + excludeclasses[i]).prop('checked', true); } } setup_excludeclass_list = function() { @@ -412,10 +412,10 @@ firstfield.focus() }); $('#id_layerdialog_select_all').click(function (e) { - $('.filterlayercheckbox').attr('checked', true); + $('.filterlayercheckbox').prop('checked', true); }); $('#id_layerdialog_select_none').click(function (e) { - $('.filterlayercheckbox').attr('checked', false); + $('.filterlayercheckbox').prop('checked', false); }); $('#id_layerdialog_ok').click(function (e) { update_selected_layer_display() @@ -424,7 +424,7 @@ setup_layer_list() }); $('#id_excludeclassdialog_select_none').click(function (e) { - $('.filterclasscheckbox').attr('checked', false); + $('.filterclasscheckbox').prop('checked', false); }); $('#id_excludeclassdialog_ok').click(function (e) { update_excludeclasses_display() diff --git a/templates/layerindex/duplicates.html b/templates/layerindex/duplicates.html index 71c3922..f5eed6c 100644 --- a/templates/layerindex/duplicates.html +++ b/templates/layerindex/duplicates.html @@ -186,16 +186,16 @@ firstfield.focus() }); $('#id_select_all').click(function (e) { - $('.filterlayercheckbox').attr('checked', true); + $('.filterlayercheckbox').prop('checked', true); }); $('#id_select_none').click(function (e) { - $('.filterlayercheckbox').attr('checked', false); + $('.filterlayercheckbox').prop('checked', false); }); $('#id_cancel').click(function (e) { - $('.filterlayercheckbox').attr('checked', false); + $('.filterlayercheckbox').prop('checked', false); showlayers = {{ showlayers }} for(i in showlayers) { - $('#id_layer_' + showlayers[i]).attr('checked', true); + $('#id_layer_' + showlayers[i]).prop('checked', true); } });