Use prop() instead of attr() to set checked property

Using attr('checked') is not reliable, the jQuery documentation
recommends using prop() with jQuery 1.6 or later and it definitely works
more reliably in my testing.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
This commit is contained in:
Paul Eggleton 2018-11-06 16:29:57 +13:00
parent 3c25eda61e
commit b940e7c431
2 changed files with 11 additions and 11 deletions

View File

@ -341,10 +341,10 @@
} }
} }
select_layer_checkboxes = function() { select_layer_checkboxes = function() {
$('.filterlayercheckbox').attr('checked', false); $('.filterlayercheckbox').prop('checked', false);
selectedlayers = $('#id_selectedlayers').val().split(','); selectedlayers = $('#id_selectedlayers').val().split(',');
for(i in selectedlayers) { for(i in selectedlayers) {
$('#id_layercheckbox_' + selectedlayers[i]).attr('checked', true); $('#id_layercheckbox_' + selectedlayers[i]).prop('checked', true);
} }
} }
setup_layer_list = function() { setup_layer_list = function() {
@ -372,10 +372,10 @@
} }
} }
select_excludeclass_checkboxes = function() { select_excludeclass_checkboxes = function() {
$('.filterclasscheckbox').attr('checked', false); $('.filterclasscheckbox').prop('checked', false);
excludeclasses = $('#id_excludeclasses').val().split(','); excludeclasses = $('#id_excludeclasses').val().split(',');
for(i in excludeclasses) { for(i in excludeclasses) {
$('#id_classcheckbox_' + excludeclasses[i]).attr('checked', true); $('#id_classcheckbox_' + excludeclasses[i]).prop('checked', true);
} }
} }
setup_excludeclass_list = function() { setup_excludeclass_list = function() {
@ -412,10 +412,10 @@
firstfield.focus() firstfield.focus()
}); });
$('#id_layerdialog_select_all').click(function (e) { $('#id_layerdialog_select_all').click(function (e) {
$('.filterlayercheckbox').attr('checked', true); $('.filterlayercheckbox').prop('checked', true);
}); });
$('#id_layerdialog_select_none').click(function (e) { $('#id_layerdialog_select_none').click(function (e) {
$('.filterlayercheckbox').attr('checked', false); $('.filterlayercheckbox').prop('checked', false);
}); });
$('#id_layerdialog_ok').click(function (e) { $('#id_layerdialog_ok').click(function (e) {
update_selected_layer_display() update_selected_layer_display()
@ -424,7 +424,7 @@
setup_layer_list() setup_layer_list()
}); });
$('#id_excludeclassdialog_select_none').click(function (e) { $('#id_excludeclassdialog_select_none').click(function (e) {
$('.filterclasscheckbox').attr('checked', false); $('.filterclasscheckbox').prop('checked', false);
}); });
$('#id_excludeclassdialog_ok').click(function (e) { $('#id_excludeclassdialog_ok').click(function (e) {
update_excludeclasses_display() update_excludeclasses_display()

View File

@ -186,16 +186,16 @@
firstfield.focus() firstfield.focus()
}); });
$('#id_select_all').click(function (e) { $('#id_select_all').click(function (e) {
$('.filterlayercheckbox').attr('checked', true); $('.filterlayercheckbox').prop('checked', true);
}); });
$('#id_select_none').click(function (e) { $('#id_select_none').click(function (e) {
$('.filterlayercheckbox').attr('checked', false); $('.filterlayercheckbox').prop('checked', false);
}); });
$('#id_cancel').click(function (e) { $('#id_cancel').click(function (e) {
$('.filterlayercheckbox').attr('checked', false); $('.filterlayercheckbox').prop('checked', false);
showlayers = {{ showlayers }} showlayers = {{ showlayers }}
for(i in showlayers) { for(i in showlayers) {
$('#id_layer_' + showlayers[i]).attr('checked', true); $('#id_layer_' + showlayers[i]).prop('checked', true);
} }
}); });
</script> </script>