From cc1d82f893468faa4ae8157af5a63a3189c5f869 Mon Sep 17 00:00:00 2001 From: Paul Eggleton Date: Mon, 7 Nov 2016 15:14:24 +1300 Subject: [PATCH] utils: fix error in runcmd() if printerr=False If you specified printerr=False we were referring to the output variable that hadn't been set. Looks like I broke this back in 2013 in 93ce26f21cdbbd8a645792359cde87acf05144d7. Signed-off-by: Paul Eggleton --- layerindex/utils.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/layerindex/utils.py b/layerindex/utils.py index e3be631..9248077 100644 --- a/layerindex/utils.py +++ b/layerindex/utils.py @@ -190,9 +190,9 @@ def runcmd(cmd, destdir=None, printerr=True, logger=None): subprocess.check_call(cmd, stdout=out, stderr=out, cwd=destdir, shell=True) except subprocess.CalledProcessError as e: out.seek(0) + output = out.read() + output = output.decode('ascii').strip() if printerr: - output = out.read() - output = output.decode('ascii').strip() if logger: logger.error("%s" % output) else: