From e9915dd3590e19ef55fc19c5330fba7e6b39bd08 Mon Sep 17 00:00:00 2001 From: Paul Eggleton Date: Tue, 15 Jan 2019 11:44:30 +1300 Subject: [PATCH] dockersetup: use with open in readfile/writefile Best practice to ensure files always get closed. Signed-off-by: Paul Eggleton --- dockersetup.py | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/dockersetup.py b/dockersetup.py index c1e875b..cb849ec 100755 --- a/dockersetup.py +++ b/dockersetup.py @@ -372,15 +372,12 @@ def generatepasswords(passwordlength): return ''.join([random.SystemRandom().choice('abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789!@%^&*-_+') for i in range(passwordlength)]) def readfile(filename): - f = open(filename,'r') - filedata = f.read() - f.close() - return filedata + with open(filename, 'r') as f: + return f.read() def writefile(filename, data): - f = open(filename,'w') - f.write(data) - f.close() + with open(filename, 'w') as f: + f.write(data) ## Get user arguments and modify config files