dockersetup: use with open in readfile/writefile

Best practice to ensure files always get closed.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
This commit is contained in:
Paul Eggleton 2019-01-15 11:44:30 +13:00
parent 7a248df9f5
commit e9915dd359

View File

@ -372,15 +372,12 @@ def generatepasswords(passwordlength):
return ''.join([random.SystemRandom().choice('abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789!@%^&*-_+') for i in range(passwordlength)]) return ''.join([random.SystemRandom().choice('abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789!@%^&*-_+') for i in range(passwordlength)])
def readfile(filename): def readfile(filename):
f = open(filename,'r') with open(filename, 'r') as f:
filedata = f.read() return f.read()
f.close()
return filedata
def writefile(filename, data): def writefile(filename, data):
f = open(filename,'w') with open(filename, 'w') as f:
f.write(data) f.write(data)
f.close()
## Get user arguments and modify config files ## Get user arguments and modify config files