layerindex-web/layerindex/utils.py
Robert Yang 3ae517091b update.py: update layers in dependency order
* Problems
The update.py couldn't handle new (not only new branch, in fact, but also
existing branches, see below for more info) branch well, for example, there are
3 layers: layer_A, layer_B and layer_C, and create new branch "branch_1" for
them, and they have depends:

layer_A -> layer_B -> layer_C

The "->" means depends on.

Then run "update.py -b branch_1", there would be errors like:

ERROR: Dependency layer_B of layer_A does not have branch record for branch branch_1

Though update.py runs "update_layer.py" twice, but it didn't help since
layerbranch was None when it was failed to create in the first run.

The reason is if update.py updates layer_A firstly, it would fail since it
can't find layer_B:branch_1 in database (not added to database yet), similarly,
if add layer_B before layer_C, it would also fail. Only layer_C can be added
(assume it has no dependencies). So we have to re-run update.py again and again
to make it work, here we may have to run update.py 3 times, and more runs are
needed if the dependency chain is longer.

* Solutions:
Make update.py pass layers orderly to update_layer.py according to dependencies
can fix the problem, we can get intial dependencies from tinfoil, add an option
"-i, --initial" to update_layer.py to get them.

Not only new branch, but also existing branches may have the problem, because
collections and dependencies maybe changed in the coming update, so we can't
trust database when the layer is going to be updated, for example, if there are
10 layers in database, and 3 of them will be updated (-l layer1,layer2,layer3),
then we can not use the 3 layers' collections data from database, we need get
them from tinfoil.

* Performance improvement:
  It should be the same as before in theory, I have tested it with 97 layers:
  - Before: 11m6.472s, but only 75 layers were added, 22 ones were failed, I
    have to re-run update.py again and again (maybe 4 times to make all of
    them added). So:
    (11 * 60 + 6)/75*97/60 = 14m35s

  - Now 12m10.350s, all the layers are added in the first run.

   So about 2 minutes are saved.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
2017-07-21 08:15:53 +02:00

335 lines
11 KiB
Python

# Utilities for layerindex-web
#
# Copyright (C) 2013 Intel Corporation
# Author: Paul Eggleton <paul.eggleton@linux.intel.com>
#
# Licensed under the MIT license, see COPYING.MIT for details
import sys
import os
import tempfile
import subprocess
import logging
import time
import fcntl
def get_branch(branchname):
from layerindex.models import Branch
res = list(Branch.objects.filter(name=branchname)[:1])
if res:
return res[0]
return None
def get_layer(layername):
from layerindex.models import LayerItem
res = list(LayerItem.objects.filter(name=layername)[:1])
if res:
return res[0]
return None
def get_layer_var(config_data, var, logger):
collection = config_data.getVar('BBFILE_COLLECTIONS', True)
if collection:
collection = collection.strip()
collection_list = collection.split()
collection = collection_list[0]
layerdir = config_data.getVar('LAYERDIR', True)
if len(collection_list) > 1:
logger.warn('%s: multiple collections found, handling first one (%s) only' % (layerdir, collection))
if var == 'BBFILE_COLLECTIONS':
return collection
value = config_data.getVar('%s_%s' % (var, collection), True)
if not value:
value = config_data.getVar(var, True)
return value or ''
def is_deps_satisfied(req_col, req_ver, collections):
""" Check whether required collection and version are in collections"""
for existed_col, existed_ver in collections:
if req_col == existed_col:
# If there is no version constraint, return True when collection matches
if not req_ver:
return True
else:
# If there is no version in the found layer, then don't use this layer.
if not existed_ver:
continue
(op, dep_version) = req_ver.split()
success = bb.utils.vercmp_string_op(existed_ver, dep_version, op)
if success:
return True
# Return False when not found
return False
def get_dependency_layer(depname, version_str=None, logger=None):
from layerindex.models import LayerItem, LayerBranch
# Get any LayerBranch with a layer that has a name that matches depmod, or
# a LayerBranch that has the collection name depmod.
res = list(LayerBranch.objects.filter(layer__name=depname)) + \
list(LayerBranch.objects.filter(collection=depname))
# Nothing found, return.
if not res:
return None
# If there is no version constraint, return the first one found.
if not version_str:
return res[0].layer
(operator, dep_version) = version_str.split()
for layerbranch in res:
layer_ver = layerbranch.version
# If there is no version in the found layer, then don't use this layer.
if not layer_ver:
continue
try:
success = bb.utils.vercmp_string_op(layer_ver, version_str, operator)
except bb.utils.VersionStringException as vse:
raise vse
if success:
return layerbranch.layer
return None
def add_dependencies(layerbranch, config_data, logger=None):
_add_dependency("LAYERDEPENDS", 'dependency', layerbranch, config_data, logger=logger)
def add_recommends(layerbranch, config_data, logger=None):
_add_dependency("LAYERRECOMMENDS", 'recommends', layerbranch, config_data, logger=logger, required=False)
def _add_dependency(var, name, layerbranch, config_data, logger=None, required=True):
from layerindex.models import LayerBranch, LayerDependency
layer_name = layerbranch.layer.name
var_name = layer_name
if layerbranch.collection:
var_name = layerbranch.collection
dep_list = config_data.getVar("%s_%s" % (var, var_name), True)
if not dep_list:
return
try:
dep_dict = bb.utils.explode_dep_versions2(dep_list)
except bb.utils.VersionStringException as vse:
logger.debug('Error parsing %s_%s for %s\n%s' % (var, var_name, layer_name, str(vse)))
return
need_remove = None
for dep, ver_list in list(dep_dict.items()):
ver_str = None
if ver_list:
ver_str = ver_list[0]
try:
dep_layer = get_dependency_layer(dep, ver_str, logger)
except bb.utils.VersionStringException as vse:
if logger:
logger.error('Error getting %s %s for %s\n%s' %(name, dep. layer_name, str(vse)))
continue
# No layer found.
if not dep_layer:
if logger:
logger.error('Cannot resolve %s %s (version %s) for %s' % (name, dep, ver_str, layer_name))
continue
# Preparing to remove obsolete ones
if not need_remove:
need_remove = LayerDependency.objects.filter(layerbranch=layerbranch).filter(required=required).exclude(dependency=dep_layer)
else:
need_remove = need_remove.exclude(dependency=dep_layer)
# Skip existing entries.
existing = list(LayerDependency.objects.filter(layerbranch=layerbranch).filter(required=required).filter(dependency=dep_layer))
if existing:
logger.debug('Skipping %s - already a dependency for %s' % (dep, layer_name))
continue
if logger:
logger.debug('Adding %s %s to %s' % (name, dep_layer.name, layer_name))
layerdep = LayerDependency()
layerdep.layerbranch = layerbranch
layerdep.dependency = dep_layer
layerdep.required = required
layerdep.save()
if need_remove:
import settings
remove_layer_dependencies = getattr(settings, 'REMOVE_LAYER_DEPENDENCIES', False)
if remove_layer_dependencies:
logger.info('Removing obsolete dependencies "%s" for layer %s' % (need_remove, layer_name))
need_remove.delete()
else:
logger.warn('Dependencies "%s" are not in %s\'s conf/layer.conf' % (need_remove, layer_name))
logger.warn('Either set REMOVE_LAYER_DEPENDENCIES to remove them from the database, or fix conf/layer.conf')
def set_layerbranch_collection_version(layerbranch, config_data, logger=None):
layerbranch.collection = config_data.getVar('BBFILE_COLLECTIONS', True)
ver_str = "LAYERVERSION_"
if layerbranch.collection:
layerbranch.collection = layerbranch.collection.strip()
ver_str += layerbranch.collection
layerbranch.version = config_data.getVar(ver_str, True)
def setup_tinfoil(bitbakepath, enable_tracking):
sys.path.insert(0, bitbakepath + '/lib')
import bb.tinfoil
import bb.cooker
import bb.data
try:
tinfoil = bb.tinfoil.Tinfoil(tracking=enable_tracking)
except TypeError:
# old API
tinfoil = bb.tinfoil.Tinfoil()
if enable_tracking:
tinfoil.cooker.enableDataTracking()
tinfoil.prepare(config_only = True)
return tinfoil
def explode_dep_versions2(bitbakepath, deps):
bblib = bitbakepath + '/lib'
if not bblib in sys.path:
sys.path.insert(0, bblib)
import bb.utils
return bb.utils.explode_dep_versions2(deps)
def checkout_layer_branch(layerbranch, repodir, logger=None):
branchname = layerbranch.branch.name
if layerbranch.actual_branch:
branchname = layerbranch.actual_branch
out = runcmd("git checkout origin/%s" % branchname, repodir, logger=logger)
out = runcmd("git clean -f -x", repodir, logger=logger)
def is_layer_valid(layerdir):
conf_file = os.path.join(layerdir, "conf", "layer.conf")
if not os.path.isfile(conf_file):
return False
return True
def is_branch_valid(layerdir, branch):
import git
g = git.cmd.Git(layerdir)
assert g.rev_parse('--is-bare-repository') == 'false'
try:
g.rev_parse('--verify', 'origin/%s' % branch)
except git.exc.GitCommandError:
return False
return True
def parse_conf(conf_file, d):
if hasattr(bb.parse, "handle"):
# Newer BitBake
data = bb.parse.handle(conf_file, d, include=True)
else:
# Older BitBake (1.18 and below)
data = bb.cooker._parse(conf_file, d)
return data
def parse_layer_conf(layerdir, data, logger=None):
conf_file = os.path.join(layerdir, "conf", "layer.conf")
if not is_layer_valid(layerdir):
if logger:
logger.error("Cannot find layer.conf: %s"% conf_file)
return
data.setVar('LAYERDIR', str(layerdir))
data = parse_conf(conf_file, data)
data.expandVarref('LAYERDIR')
def runcmd(cmd, destdir=None, printerr=True, logger=None):
"""
execute command, raise CalledProcessError if fail
return output if succeed
"""
if logger:
logger.debug("run cmd '%s' in %s" % (cmd, os.getcwd() if destdir is None else destdir))
out = tempfile.TemporaryFile()
try:
subprocess.check_call(cmd, stdout=out, stderr=out, cwd=destdir, shell=True)
except subprocess.CalledProcessError as e:
out.seek(0)
output = out.read()
output = output.decode('ascii').strip()
if printerr:
if logger:
logger.error("%s" % output)
else:
sys.stderr.write("%s\n" % output)
e.output = output
raise e
out.seek(0)
output = out.read()
output = output.decode('ascii').strip()
if logger:
logger.debug("output: %s" % output.rstrip() )
return output
def setup_django():
import django
# Get access to our Django model
newpath = os.path.abspath(os.path.dirname(__file__) + '/..')
sys.path.append(newpath)
os.environ['DJANGO_SETTINGS_MODULE'] = 'settings'
django.setup()
def logger_create(name):
logger = logging.getLogger(name)
loggerhandler = logging.StreamHandler()
loggerhandler.setFormatter(logging.Formatter("%(levelname)s: %(message)s"))
logger.addHandler(loggerhandler)
logger.setLevel(logging.INFO)
return logger
class ListHandler(logging.Handler):
"""Logging handler which accumulates formatted log records in a list, returning the list on demand"""
def __init__(self):
self.log = []
logging.Handler.__init__(self, logging.WARNING)
def emit(self, record):
self.log.append('%s\n' % self.format(record))
def read(self):
log = self.log
self.log = []
return log
def lock_file(fn):
starttime = time.time()
while True:
lock = open(fn, 'w')
try:
fcntl.flock(lock, fcntl.LOCK_EX | fcntl.LOCK_NB)
return lock
except IOError:
lock.close()
if time.time() - starttime > 30:
return None
def unlock_file(lock):
fcntl.flock(lock, fcntl.LOCK_UN)
def chain_unique(*iterables):
"""Chain unique objects in a list of querysets, preserving order"""
seen = set()
for element in iterables:
for item in element:
k = item.id
if k not in seen:
seen.add(k)
yield item