mirror of
https://github.com/nxp-imx/linux-imx.git
synced 2025-07-08 10:25:20 +02:00
wifi: rtw89: correct base HT rate mask for firmware
[ Upstream commit 45742881f9
]
Coverity reported that u8 rx_mask << 24 will become signed 32 bits, which
casting to unsigned 64 bits will do sign extension. For example,
putting 0x80000000 (signed 32 bits) to a u64 variable will become
0xFFFFFFFF_80000000.
The real case we meet is:
rx_mask[0...3] = ff ff 00 00
ra_mask = 0xffffffff_ff0ff000
After this fix:
rx_mask[0...3] = ff ff 00 00
ra_mask = 0x00000000_ff0ff000
Fortunately driver does bitwise-AND with incorrect ra_mask and supported
rates (1ss and 2ss rate only) afterward, so the final rate mask of
original code is still correct.
Addresses-Coverity-ID: 1504762 ("Unintended sign extension")
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20240809072012.84152-5-pkshih@realtek.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
d4c4653b60
commit
239ac7faea
|
@ -284,8 +284,8 @@ static void rtw89_phy_ra_sta_update(struct rtw89_dev *rtwdev,
|
|||
csi_mode = RTW89_RA_RPT_MODE_HT;
|
||||
ra_mask |= ((u64)sta->deflink.ht_cap.mcs.rx_mask[3] << 48) |
|
||||
((u64)sta->deflink.ht_cap.mcs.rx_mask[2] << 36) |
|
||||
(sta->deflink.ht_cap.mcs.rx_mask[1] << 24) |
|
||||
(sta->deflink.ht_cap.mcs.rx_mask[0] << 12);
|
||||
((u64)sta->deflink.ht_cap.mcs.rx_mask[1] << 24) |
|
||||
((u64)sta->deflink.ht_cap.mcs.rx_mask[0] << 12);
|
||||
high_rate_masks = rtw89_ra_mask_ht_rates;
|
||||
if (sta->deflink.ht_cap.cap & IEEE80211_HT_CAP_RX_STBC)
|
||||
stbc_en = 1;
|
||||
|
|
Loading…
Reference in New Issue
Block a user