MIRRORS/linux-imx
1
0
Fork 0
mirror of https://github.com/nxp-imx/linux-imx.git synced 2025-07-07 18:05:21 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

usb: uas: set host status byte on data completion error

Browse Source 
[ Upstream commit 9d32685a25 ]

Set the host status byte when a data completion error is encountered
otherwise the upper layer may end up using the invalid zero'ed data.
The following output was observed from scsi/sd.c prior to this fix.

[   11.872824] sd 0:0:0:1: [sdf] tag#9 data cmplt err -75 uas-tag 1 inflight:
[   11.872826] sd 0:0:0:1: [sdf] tag#9 CDB: Read capacity(16) 9e 10 00 00 00 00 00 00 00 00 00 00 00 20 00 00
[   11.872830] sd 0:0:0:1: [sdf] Sector size 0 reported, assuming 512.

Signed-off-by: Shantanu Goel <sgoel01@yahoo.com>
Acked-by: Oliver Neukum <oneukum@suse.com>
Link: https://lore.kernel.org/r/87msnx4ec6.fsf@yahoo.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Shantanu Goel 2024-06-06 23:32:57 -04:00 committed by Greg Kroah-Hartman
parent d22d72e2bf
commit 4292441b87
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/usb/storage/uas.c
View File

@ -422,6 +422,7 @@ static void uas_data_cmplt(struct urb *urb)
uas_log_cmd_state(cmnd, "data cmplt err", status); uas_log_cmd_state(cmnd, "data cmplt err", status);
/* error: no data transfered */ /* error: no data transfered */
scsi_set_resid(cmnd, sdb->length); scsi_set_resid(cmnd, sdb->length);
set_host_byte(cmnd, DID_ERROR);
} else { } else {
scsi_set_resid(cmnd, sdb->length - urb->actual_length); scsi_set_resid(cmnd, sdb->length - urb->actual_length);
} }