MIRRORS/linux-imx
1
0
Fork 0
mirror of https://github.com/nxp-imx/linux-imx.git synced 2025-07-08 10:25:20 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

drm/amdgpu/pm: Check input value for CUSTOM profile mode setting on legacy SOCs

Browse Source 
[ Upstream commit df0a9bd92f ]

Check the input value for CUSTOM profile mode setting on legacy
SOCs. Otherwise we may use uninitalized value of input[]

Signed-off-by: Ma Jun <Jun.Ma2@amd.com>
Reviewed-by: Yang Wang <kevinyang.wang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Ma Jun 2024-05-10 10:05:21 +08:00 committed by Greg Kroah-Hartman
parent eba7c58b7a
commit 58350786db
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c
View File

@ -5641,7 +5641,7 @@ static int smu7_set_power_profile_mode(struct pp_hwmgr *hwmgr, long *input, uint
mode = input[size]; mode = input[size];
switch (mode) { switch (mode) {
case PP_SMC_POWER_PROFILE_CUSTOM: case PP_SMC_POWER_PROFILE_CUSTOM:
if (size < 8 && size != 0) if (size != 8 && size != 0)
return -EINVAL; return -EINVAL;
/* If only CUSTOM is passed in, use the saved values. Check /* If only CUSTOM is passed in, use the saved values. Check
* that we actually have a CUSTOM profile by ensuring that * that we actually have a CUSTOM profile by ensuring that

8
drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.c
View File

@ -4102,9 +4102,11 @@ static int vega20_set_power_profile_mode(struct pp_hwmgr *hwmgr, long *input, ui
if (power_profile_mode == PP_SMC_POWER_PROFILE_CUSTOM) { if (power_profile_mode == PP_SMC_POWER_PROFILE_CUSTOM) {
struct vega20_hwmgr *data = struct vega20_hwmgr *data =
(struct vega20_hwmgr *)(hwmgr->backend); (struct vega20_hwmgr *)(hwmgr->backend);
if (size == 0 && !data->is_custom_profile_set)
if (size != 10 && size != 0)
return -EINVAL; return -EINVAL;
if (size < 10 && size != 0)
if (size == 0 && !data->is_custom_profile_set)
return -EINVAL; return -EINVAL;
result = vega20_get_activity_monitor_coeff(hwmgr, result = vega20_get_activity_monitor_coeff(hwmgr,
@ -4166,6 +4168,8 @@ static int vega20_set_power_profile_mode(struct pp_hwmgr *hwmgr, long *input, ui
activity_monitor.Fclk_PD_Data_error_coeff = input[8]; activity_monitor.Fclk_PD_Data_error_coeff = input[8];
activity_monitor.Fclk_PD_Data_error_rate_coeff = input[9]; activity_monitor.Fclk_PD_Data_error_rate_coeff = input[9];
break; break;
default:
return -EINVAL;
} }
result = vega20_set_activity_monitor_coeff(hwmgr, result = vega20_set_activity_monitor_coeff(hwmgr,