From 5a641fff57e8c7779588c82f891231edd2f3de7d Mon Sep 17 00:00:00 2001 From: Vladimir Oltean Date: Thu, 18 Jan 2024 14:30:12 +0200 Subject: [PATCH] fsl_qbman: add explicit fallthrough to qman_destroy_fq() Fixes clang-16 build breakage: drivers/staging/fsl_qbman/qman_high.c:1723:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough] case qman_fq_state_oos: ^ drivers/staging/fsl_qbman/qman_high.c:1723:2: note: insert '__attribute__((fallthrough));' to silence this warning case qman_fq_state_oos: ^ __attribute__((fallthrough)); drivers/staging/fsl_qbman/qman_high.c:1723:2: note: insert 'break;' to avoid fall-through case qman_fq_state_oos: ^ break; Signed-off-by: Vladimir Oltean Reviewed-by: Camelia Groza --- drivers/staging/fsl_qbman/qman_high.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl_qbman/qman_high.c b/drivers/staging/fsl_qbman/qman_high.c index 03ae2eb067e5..09b9e422090a 100644 --- a/drivers/staging/fsl_qbman/qman_high.c +++ b/drivers/staging/fsl_qbman/qman_high.c @@ -1776,12 +1776,12 @@ EXPORT_SYMBOL(qman_create_fq); void qman_destroy_fq(struct qman_fq *fq, u32 flags __maybe_unused) { - /* We don't need to lock the FQ as it is a pre-condition that the FQ be * quiesced. Instead, run some checks. */ switch (fq->state) { case qman_fq_state_parked: DPA_ASSERT(flags & QMAN_FQ_DESTROY_PARKED); + fallthrough; case qman_fq_state_oos: if (fq_isset(fq, QMAN_FQ_FLAG_DYNAMIC_FQID)) qman_release_fqid(fq->fqid);