MIRRORS/linux-imx
1
0
Fork 0
mirror of https://github.com/nxp-imx/linux-imx.git synced 2025-07-08 18:35:20 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

serial: uart_poll_init() should power on the UART

Browse Source 
On Qualcomm devices which use the "geni" serial driver, kdb/kgdb won't
be very happy if you use it but the resources of the port haven't been
powered on. Today kdb/kgdb rely on someone else powering the port
on. This could be the normal kernel console or an agetty running.
Let's fix this to explicitly power things on when setting up a polling
driver.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20230316132027.RESEND.1.I106c39498d8094c6f5e7ada42c7db17aa5c64e48@changeid
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Douglas Anderson 2023-03-16 13:20:56 -07:00 committed by Greg Kroah-Hartman
parent afe3154ba8
commit 5e227ef2aa
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/tty/serial/serial_core.c
View File

@ -2590,6 +2590,7 @@ static int uart_poll_init(struct tty_driver *driver, int line, char *options)
{ {
struct uart_driver *drv = driver->driver_state; struct uart_driver *drv = driver->driver_state;
struct uart_state *state = drv->state + line; struct uart_state *state = drv->state + line;
enum uart_pm_state pm_state;
struct tty_port *tport; struct tty_port *tport;
struct uart_port *port; struct uart_port *port;
int baud = 9600; int baud = 9600;
@ -2607,6 +2608,9 @@ static int uart_poll_init(struct tty_driver *driver, int line, char *options)
goto out; goto out;
} }
pm_state = state->pm_state;
uart_change_pm(state, UART_PM_STATE_ON);
if (port->ops->poll_init) { if (port->ops->poll_init) {
/* /*
* We don't set initialized as we only initialized the hw, * We don't set initialized as we only initialized the hw,
@ -2623,6 +2627,8 @@ static int uart_poll_init(struct tty_driver *driver, int line, char *options)
console_list_unlock(); console_list_unlock();
} }
out: out:
if (ret)
uart_change_pm(state, pm_state);
mutex_unlock(&tport->mutex); mutex_unlock(&tport->mutex);
return ret; return ret;
} }