usb: renesas_usbhs: Fix DMAC sequence for receiving zero-length packet

commit 29c7f3e68e upstream.

The DREQE bit of the DnFIFOSEL should be set to 1 after the DE bit of
USB-DMAC on R-Car SoCs is set to 1 after the USB-DMAC received a
zero-length packet. Otherwise, a transfer completion interruption
of USB-DMAC doesn't happen. Even if the driver changes the sequence,
normal operations (transmit/receive without zero-length packet) will
not cause any side-effects. So, this patch fixes the sequence anyway.

Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
[shimoda: revise the commit log]
Fixes: e73a9891b3 ("usb: renesas_usbhs: add DMAEngine support")
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
This commit is contained in:
Kazuya Mizuguchi 2017-10-02 14:01:41 +09:00 committed by Ben Hutchings
parent 64a4896ee6
commit 7671215815

View File

@ -817,8 +817,8 @@ static void usbhsf_dma_prepare_tasklet(unsigned long data)
dev_dbg(dev, " %s %d (%d/ %d)\n",
fifo->name, usbhs_pipe_number(pipe), pkt->length, pkt->zero);
usbhsf_dma_start(pipe, fifo);
dma_async_issue_pending(chan);
usbhsf_dma_start(pipe, fifo);
xfer_work_end:
usbhs_unlock(priv, flags);