MIRRORS/linux-imx
1
0
Fork 0
mirror of https://github.com/nxp-imx/linux-imx.git synced 2026-01-27 12:35:36 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

LF-14922 net: enetc: Fix null pointer accces in fsl-netc-prb-ierb driver probe

Browse Source 
Fix NULL pointer access occurring when the 'netc-interfaces' property
is missing or not properly defined in DTS. The parsing function,
netc_prb_parse_if, expects to find "netc-interfaces" property
definition to allocate memory for pi->ifmode array.

Signed-off-by: Florin Leotescu <florin.leotescu@nxp.com>
Reviewed-by: Wei Fang <wei.fang@nxp.com>
This commit is contained in:
Florin Leotescu 2025-02-07 14:39:57 +02:00
parent d8f7322db0
commit 86aad7676d
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/net/ethernet/freescale/enetc/netc_prb_ierb.c
View File

@ -449,7 +449,7 @@ static int netc_prb_parse_if(struct netc_prb_ierb *pi, struct device *dev)
int ret, count;
count = of_property_count_u32_elems(node, "netc-interfaces");
if (count < 1)
if (count != 3)
return -EINVAL;
pi->ifmode = devm_kcalloc(dev, count, sizeof(pi->ifmode), GFP_KERNEL);
@ -535,7 +535,10 @@ static int netc_prb_ierb_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, pi);
netc_prb_parse_if(pi, &pdev->dev);
err = netc_prb_parse_if(pi, &pdev->dev);
if (err)
goto disable_ipg_clk;
netc_netcmix_init(pdev);
err = netc_ierb_init(pdev);