mirror of
https://github.com/nxp-imx/linux-imx.git
synced 2025-07-07 01:45:18 +02:00
drm/amd/display: Run DC_LOG_DC after checking link->link_enc
[ Upstream commit 3a82f62b0d
]
[WHAT]
The DC_LOG_DC should be run after link->link_enc is checked, not before.
This fixes 1 REVERSE_INULL issue reported by Coverity.
Reviewed-by: Rodrigo Siqueira <rodrigo.siqueira@amd.com>
Signed-off-by: Alex Hung <alex.hung@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
b2a50ffdd1
commit
874e3bb302
|
@ -629,14 +629,14 @@ static bool construct_phy(struct dc_link *link,
|
||||||
link->link_enc =
|
link->link_enc =
|
||||||
link->dc->res_pool->funcs->link_enc_create(dc_ctx, &enc_init_data);
|
link->dc->res_pool->funcs->link_enc_create(dc_ctx, &enc_init_data);
|
||||||
|
|
||||||
DC_LOG_DC("BIOS object table - DP_IS_USB_C: %d", link->link_enc->features.flags.bits.DP_IS_USB_C);
|
|
||||||
DC_LOG_DC("BIOS object table - IS_DP2_CAPABLE: %d", link->link_enc->features.flags.bits.IS_DP2_CAPABLE);
|
|
||||||
|
|
||||||
if (!link->link_enc) {
|
if (!link->link_enc) {
|
||||||
DC_ERROR("Failed to create link encoder!\n");
|
DC_ERROR("Failed to create link encoder!\n");
|
||||||
goto link_enc_create_fail;
|
goto link_enc_create_fail;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
DC_LOG_DC("BIOS object table - DP_IS_USB_C: %d", link->link_enc->features.flags.bits.DP_IS_USB_C);
|
||||||
|
DC_LOG_DC("BIOS object table - IS_DP2_CAPABLE: %d", link->link_enc->features.flags.bits.IS_DP2_CAPABLE);
|
||||||
|
|
||||||
/* Update link encoder tracking variables. These are used for the dynamic
|
/* Update link encoder tracking variables. These are used for the dynamic
|
||||||
* assignment of link encoders to streams.
|
* assignment of link encoders to streams.
|
||||||
*/
|
*/
|
||||||
|
|
Loading…
Reference in New Issue
Block a user