MIRRORS/linux-imx
1
0
Fork 0
mirror of https://github.com/nxp-imx/linux-imx.git synced 2025-07-08 18:35:20 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

f2fs: stop checkpoint when get a out-of-bounds segment

Browse Source 
[ Upstream commit f9e28904e6 ]

There is low probability that an out-of-bounds segment will be got
on a small-capacity device. In order to prevent subsequent write requests
allocating block address from this invalid segment, which may cause
unexpected issue, stop checkpoint should be performed.

Also introduce a new stop cp reason: STOP_CP_REASON_NO_SEGMENT.

Note, f2fs_stop_checkpoint(, false) is complex and it may sleep, so we should
move it outside segmap_lock spinlock coverage in get_new_segment().

Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Zhiguo Niu 2024-02-20 14:11:24 +08:00 committed by Greg Kroah-Hartman
parent 23494bccd2
commit 881613a975
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
fs/f2fs/segment.c
View File

@ -2646,6 +2646,7 @@ static void get_new_segment(struct f2fs_sb_info *sbi,
unsigned int old_zoneno = GET_ZONE_FROM_SEG(sbi, *newseg); unsigned int old_zoneno = GET_ZONE_FROM_SEG(sbi, *newseg);
bool init = true; bool init = true;
int i; int i;
int ret = 0;
spin_lock(&free_i->segmap_lock); spin_lock(&free_i->segmap_lock);
@ -2670,7 +2671,10 @@ find_other_zone:
if (secno >= MAIN_SECS(sbi)) { if (secno >= MAIN_SECS(sbi)) {
secno = find_first_zero_bit(free_i->free_secmap, secno = find_first_zero_bit(free_i->free_secmap,
MAIN_SECS(sbi)); MAIN_SECS(sbi));
f2fs_bug_on(sbi, secno >= MAIN_SECS(sbi)); if (secno >= MAIN_SECS(sbi)) {
ret = -ENOSPC;
goto out_unlock;
}
} }
segno = GET_SEG_FROM_SEC(sbi, secno); segno = GET_SEG_FROM_SEC(sbi, secno);
zoneno = GET_ZONE_FROM_SEC(sbi, secno); zoneno = GET_ZONE_FROM_SEC(sbi, secno);
@ -2700,7 +2704,13 @@ got_it:
f2fs_bug_on(sbi, test_bit(segno, free_i->free_segmap)); f2fs_bug_on(sbi, test_bit(segno, free_i->free_segmap));
__set_inuse(sbi, segno); __set_inuse(sbi, segno);
*newseg = segno; *newseg = segno;
out_unlock:
spin_unlock(&free_i->segmap_lock); spin_unlock(&free_i->segmap_lock);
if (ret) {
f2fs_stop_checkpoint(sbi, false, STOP_CP_REASON_NO_SEGMENT);
f2fs_bug_on(sbi, 1);
}
} }
static void reset_curseg(struct f2fs_sb_info *sbi, int type, int modified) static void reset_curseg(struct f2fs_sb_info *sbi, int type, int modified)

1
include/linux/f2fs_fs.h
View File

@ -76,6 +76,7 @@ enum stop_cp_reason {
STOP_CP_REASON_CORRUPTED_SUMMARY, STOP_CP_REASON_CORRUPTED_SUMMARY,
STOP_CP_REASON_UPDATE_INODE, STOP_CP_REASON_UPDATE_INODE,
STOP_CP_REASON_FLUSH_FAIL, STOP_CP_REASON_FLUSH_FAIL,
STOP_CP_REASON_NO_SEGMENT,
STOP_CP_REASON_MAX, STOP_CP_REASON_MAX,
}; };