MIRRORS/linux-imx
1
0
Fork 0
mirror of https://github.com/nxp-imx/linux-imx.git synced 2026-01-27 12:35:36 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

usb: dwc3: imx8mp: add snps,tx-max-burst property to limit tx maxburst on i.MX95 A1

Browse Source 
When USB3.0 host controller send data to OUT endpoint of USB device,
the data may be corrupted on USB bus if the controller send more than
4 1024 byte packets in one data burst transfer. This can be workaround
by changing the max burst size for tx transfer. According to the testing,
set max burst size to 4 can work fine for both U-disk and USB SSD devices.
This patch will also set snps,tx-thr-num-pkt to 1, although this property
doesn't have impact on the performance, but it's needed to make
snps,tx-max-burst take effect.

To limit tx maxburst on i.MX95 A1, this will call soc_device_match() to
match A1 chip.

Reviewed-by: Jun Li <jun.li@nxp.com>
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
Acked-by: Jason Liu <jason.hui.liu@nxp.com>
This commit is contained in:
Xu Yang 2025-04-22 12:46:11 +08:00 committed by Jason Liu
parent c5e8139354
commit 8ae0b84079
1 changed files with 50 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
drivers/usb/dwc3/dwc3-imx8mp.c
View File

@ -15,6 +15,7 @@
#include <linux/of_platform.h>
#include <linux/platform_device.h>
#include <linux/pm_runtime.h>
#include <linux/sys_soc.h>
#include "../host/xhci.h"
#include "core.h"
@ -58,6 +59,8 @@ struct dwc3_imx8mp {
struct clk *hsio_clk;
struct clk *suspend_clk;
int irq;
u8 tx_maxburst;
u8 tx_thr_num;
bool pm_suspended;
bool wakeup_pending;
};
@ -188,6 +191,45 @@ static struct of_dev_auxdata dwc3_imx8mp_auxdata[] = {
{},
};
static const struct soc_device_attribute imx95_rev_1_x_soc_devices[] = {
{ .soc_id = "i.MX95", .revision = "1.0" },
{ .soc_id = "i.MX95", .revision = "1.1" },
{ /* sentinel */ }
};
static int dwc3_imx95_limit_tx_maxburst(struct dwc3_imx8mp *dwc3_imx,
struct device_node *dwc3_node)
{
struct device *dev = dwc3_imx->dev;
struct property *prop;
int ret;
dwc3_imx->tx_maxburst = 4;
dwc3_imx->tx_thr_num = 1;
prop = devm_kzalloc(dev, sizeof(*prop), GFP_KERNEL);
if (!prop)
return -ENOMEM;
prop->name = "snps,tx-max-burst";
prop->value = &dwc3_imx->tx_maxburst;
prop->length = sizeof(u8);
ret = of_add_property(dwc3_node, prop);
if (ret)
return ret;
prop = devm_kzalloc(dev, sizeof(*prop), GFP_KERNEL);
if (!prop)
return -ENOMEM;
prop->name = "snps,tx-thr-num-pkt";
prop->value = &dwc3_imx->tx_thr_num;
prop->length = sizeof(u8);
ret = of_add_property(dwc3_node, prop);
return ret;
}
static int dwc3_imx8mp_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
@ -271,6 +313,14 @@ static int dwc3_imx8mp_probe(struct platform_device *pdev)
goto disable_rpm;
}
if (soc_device_match(imx95_rev_1_x_soc_devices)) {
err = dwc3_imx95_limit_tx_maxburst(dwc3_imx, dwc3_np);
if (err) {
dev_err(dev, "failed to limit tx maxburst for i.MX95 A1\n");
goto disable_rpm;
}
}
err = of_platform_populate(node, NULL, dwc3_imx8mp_auxdata, dev);
if (err) {
dev_err(&pdev->dev, "failed to create dwc3 core\n");