mirror of
https://github.com/nxp-imx/linux-imx.git
synced 2025-07-11 11:55:28 +02:00
drm/msm/dpu: capture snapshot on the first commit_done timeout
[ Upstream commit4be445f5b6
] In order to debug commit_done timeouts, capture the devcoredump state when the first timeout occurs after the encoder has been enabled. Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Patchwork: https://patchwork.freedesktop.org/patch/579850/ Link: https://lore.kernel.org/r/20240226-fd-dpu-debug-timeout-v4-3-51eec83dde23@linaro.org Stable-dep-of:aedf02e46e
("drm/msm/dpu: move dpu_encoder's connector assignment to atomic_enable()") Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
801f49c83b
commit
8e7ef27e4e
|
@ -124,6 +124,8 @@ enum dpu_enc_rc_states {
|
||||||
* @base: drm_encoder base class for registration with DRM
|
* @base: drm_encoder base class for registration with DRM
|
||||||
* @enc_spinlock: Virtual-Encoder-Wide Spin Lock for IRQ purposes
|
* @enc_spinlock: Virtual-Encoder-Wide Spin Lock for IRQ purposes
|
||||||
* @enabled: True if the encoder is active, protected by enc_lock
|
* @enabled: True if the encoder is active, protected by enc_lock
|
||||||
|
* @commit_done_timedout: True if there has been a timeout on commit after
|
||||||
|
* enabling the encoder.
|
||||||
* @num_phys_encs: Actual number of physical encoders contained.
|
* @num_phys_encs: Actual number of physical encoders contained.
|
||||||
* @phys_encs: Container of physical encoders managed.
|
* @phys_encs: Container of physical encoders managed.
|
||||||
* @cur_master: Pointer to the current master in this mode. Optimization
|
* @cur_master: Pointer to the current master in this mode. Optimization
|
||||||
|
@ -172,6 +174,7 @@ struct dpu_encoder_virt {
|
||||||
spinlock_t enc_spinlock;
|
spinlock_t enc_spinlock;
|
||||||
|
|
||||||
bool enabled;
|
bool enabled;
|
||||||
|
bool commit_done_timedout;
|
||||||
|
|
||||||
unsigned int num_phys_encs;
|
unsigned int num_phys_encs;
|
||||||
struct dpu_encoder_phys *phys_encs[MAX_PHYS_ENCODERS_PER_VIRTUAL];
|
struct dpu_encoder_phys *phys_encs[MAX_PHYS_ENCODERS_PER_VIRTUAL];
|
||||||
|
@ -1210,6 +1213,9 @@ static void dpu_encoder_virt_atomic_enable(struct drm_encoder *drm_enc,
|
||||||
dpu_enc->dsc = dpu_encoder_get_dsc_config(drm_enc);
|
dpu_enc->dsc = dpu_encoder_get_dsc_config(drm_enc);
|
||||||
|
|
||||||
mutex_lock(&dpu_enc->enc_lock);
|
mutex_lock(&dpu_enc->enc_lock);
|
||||||
|
|
||||||
|
dpu_enc->commit_done_timedout = false;
|
||||||
|
|
||||||
cur_mode = &dpu_enc->base.crtc->state->adjusted_mode;
|
cur_mode = &dpu_enc->base.crtc->state->adjusted_mode;
|
||||||
|
|
||||||
trace_dpu_enc_enable(DRMID(drm_enc), cur_mode->hdisplay,
|
trace_dpu_enc_enable(DRMID(drm_enc), cur_mode->hdisplay,
|
||||||
|
@ -2446,6 +2452,10 @@ int dpu_encoder_wait_for_commit_done(struct drm_encoder *drm_enc)
|
||||||
DPU_ATRACE_BEGIN("wait_for_commit_done");
|
DPU_ATRACE_BEGIN("wait_for_commit_done");
|
||||||
ret = phys->ops.wait_for_commit_done(phys);
|
ret = phys->ops.wait_for_commit_done(phys);
|
||||||
DPU_ATRACE_END("wait_for_commit_done");
|
DPU_ATRACE_END("wait_for_commit_done");
|
||||||
|
if (ret == -ETIMEDOUT && !dpu_enc->commit_done_timedout) {
|
||||||
|
dpu_enc->commit_done_timedout = true;
|
||||||
|
msm_disp_snapshot_state(drm_enc->dev);
|
||||||
|
}
|
||||||
if (ret)
|
if (ret)
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue
Block a user