mirror of
https://github.com/nxp-imx/linux-imx.git
synced 2025-07-11 11:55:28 +02:00
drm/mediatek: Call drm_atomic_helper_shutdown() at shutdown time
[ Upstream commitc38896ca63
] Based on grepping through the source code this driver appears to be missing a call to drm_atomic_helper_shutdown() at system shutdown time. Among other things, this means that if a panel is in use that it won't be cleanly powered off at system shutdown time. The fact that we should call drm_atomic_helper_shutdown() in the case of OS shutdown/restart comes straight out of the kernel doc "driver instance overview" in drm_drv.c. This driver users the component model and shutdown happens in the base driver. The "drvdata" for this driver will always be valid if shutdown() is called and as of commit2a07396828
("drm/atomic-helper: drm_atomic_helper_shutdown(NULL) should be a noop") we don't need to confirm that "drm" is non-NULL. Suggested-by: Maxime Ripard <mripard@kernel.org> Reviewed-by: Maxime Ripard <mripard@kernel.org> Reviewed-by: Fei Shao <fshao@chromium.org> Tested-by: Fei Shao <fshao@chromium.org> Signed-off-by: Douglas Anderson <dianders@chromium.org> Signed-off-by: Maxime Ripard <mripard@kernel.org> Link: https://patchwork.freedesktop.org/patch/msgid/20240611102744.v2.1.I2b014f90afc4729b6ecc7b5ddd1f6dedcea4625b@changeid Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
97f71343f7
commit
b241d17aa1
|
@ -926,6 +926,13 @@ static void mtk_drm_remove(struct platform_device *pdev)
|
|||
of_node_put(private->comp_node[i]);
|
||||
}
|
||||
|
||||
static void mtk_drm_shutdown(struct platform_device *pdev)
|
||||
{
|
||||
struct mtk_drm_private *private = platform_get_drvdata(pdev);
|
||||
|
||||
drm_atomic_helper_shutdown(private->drm);
|
||||
}
|
||||
|
||||
static int mtk_drm_sys_prepare(struct device *dev)
|
||||
{
|
||||
struct mtk_drm_private *private = dev_get_drvdata(dev);
|
||||
|
@ -957,6 +964,7 @@ static const struct dev_pm_ops mtk_drm_pm_ops = {
|
|||
static struct platform_driver mtk_drm_platform_driver = {
|
||||
.probe = mtk_drm_probe,
|
||||
.remove_new = mtk_drm_remove,
|
||||
.shutdown = mtk_drm_shutdown,
|
||||
.driver = {
|
||||
.name = "mediatek-drm",
|
||||
.pm = &mtk_drm_pm_ops,
|
||||
|
|
Loading…
Reference in New Issue
Block a user