MIRRORS/linux-imx
1
0
Fork 0
mirror of https://github.com/nxp-imx/linux-imx.git synced 2025-07-13 12:49:35 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

selftests/resctrl: Fix closing IMC fds on error and open-code R+W instead of loops

Browse Source 
The imc perf fd close() calls are missing from all error paths. In
addition, get_mem_bw_imc() handles fds in a for loop but close() is
based on two fixed indexes READ and WRITE.

Open code inner for loops to READ+WRITE entries for clarity and add a
function to close() IMC fds properly in all cases.

Fixes: 7f4d257e3a ("selftests/resctrl: Add callback to start a benchmark")
Suggested-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tested-by: Babu Moger <babu.moger@amd.com>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
This commit is contained in:
Ilpo Järvinen 2024-06-10 18:14:42 +03:00 committed by Shuah Khan
parent b47619a3a3
commit c44000b653
1 changed files with 36 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
tools/testing/selftests/resctrl/resctrl_val.c
View File

@ -293,6 +293,18 @@ static int initialize_mem_bw_imc(void)
return 0; return 0;
} }
static void perf_close_imc_mem_bw(void)
{
int mc;
for (mc = 0; mc < imcs; mc++) {
if (imc_counters_config[mc][READ].fd != -1)
close(imc_counters_config[mc][READ].fd);
if (imc_counters_config[mc][WRITE].fd != -1)
close(imc_counters_config[mc][WRITE].fd);
}
}
/* /*
* get_mem_bw_imc: Memory band width as reported by iMC counters * get_mem_bw_imc: Memory band width as reported by iMC counters
* @cpu_no: CPU number that the benchmark PID is binded to * @cpu_no: CPU number that the benchmark PID is binded to
@ -306,26 +318,33 @@ static int initialize_mem_bw_imc(void)
static int get_mem_bw_imc(int cpu_no, char *bw_report, float *bw_imc) static int get_mem_bw_imc(int cpu_no, char *bw_report, float *bw_imc)
{ {
float reads, writes, of_mul_read, of_mul_write; float reads, writes, of_mul_read, of_mul_write;
int imc, j, ret; int imc, ret;
for (imc = 0; imc < imcs; imc++) {
imc_counters_config[imc][READ].fd = -1;
imc_counters_config[imc][WRITE].fd = -1;
}
/* Start all iMC counters to log values (both read and write) */ /* Start all iMC counters to log values (both read and write) */
reads = 0, writes = 0, of_mul_read = 1, of_mul_write = 1; reads = 0, writes = 0, of_mul_read = 1, of_mul_write = 1;
for (imc = 0; imc < imcs; imc++) { for (imc = 0; imc < imcs; imc++) {
for (j = 0; j < 2; j++) { ret = open_perf_event(imc, cpu_no, READ);
ret = open_perf_event(imc, cpu_no, j); if (ret)
if (ret) goto close_fds;
return -1; ret = open_perf_event(imc, cpu_no, WRITE);
} if (ret)
for (j = 0; j < 2; j++) goto close_fds;
membw_ioctl_perf_event_ioc_reset_enable(imc, j);
membw_ioctl_perf_event_ioc_reset_enable(imc, READ);
membw_ioctl_perf_event_ioc_reset_enable(imc, WRITE);
} }
sleep(1); sleep(1);
/* Stop counters after a second to get results (both read and write) */ /* Stop counters after a second to get results (both read and write) */
for (imc = 0; imc < imcs; imc++) { for (imc = 0; imc < imcs; imc++) {
for (j = 0; j < 2; j++) membw_ioctl_perf_event_ioc_disable(imc, READ);
membw_ioctl_perf_event_ioc_disable(imc, j); membw_ioctl_perf_event_ioc_disable(imc, WRITE);
} }
/* /*
@ -341,15 +360,13 @@ static int get_mem_bw_imc(int cpu_no, char *bw_report, float *bw_imc)
if (read(r->fd, &r->return_value, if (read(r->fd, &r->return_value,
sizeof(struct membw_read_format)) == -1) { sizeof(struct membw_read_format)) == -1) {
ksft_perror("Couldn't get read b/w through iMC"); ksft_perror("Couldn't get read b/w through iMC");
goto close_fds;
return -1;
} }
if (read(w->fd, &w->return_value, if (read(w->fd, &w->return_value,
sizeof(struct membw_read_format)) == -1) { sizeof(struct membw_read_format)) == -1) {
ksft_perror("Couldn't get write bw through iMC"); ksft_perror("Couldn't get write bw through iMC");
goto close_fds;
return -1;
} }
__u64 r_time_enabled = r->return_value.time_enabled; __u64 r_time_enabled = r->return_value.time_enabled;
@ -369,10 +386,7 @@ static int get_mem_bw_imc(int cpu_no, char *bw_report, float *bw_imc)
writes += w->return_value.value * of_mul_write * SCALE; writes += w->return_value.value * of_mul_write * SCALE;
} }
for (imc = 0; imc < imcs; imc++) { perf_close_imc_mem_bw();
close(imc_counters_config[imc][READ].fd);
close(imc_counters_config[imc][WRITE].fd);
}
if (strcmp(bw_report, "reads") == 0) { if (strcmp(bw_report, "reads") == 0) {
*bw_imc = reads; *bw_imc = reads;
@ -386,6 +400,10 @@ static int get_mem_bw_imc(int cpu_no, char *bw_report, float *bw_imc)
*bw_imc = reads + writes; *bw_imc = reads + writes;
return 0; return 0;
close_fds:
perf_close_imc_mem_bw();
return -1;
} }
void set_mbm_path(const char *ctrlgrp, const char *mongrp, int domain_id) void set_mbm_path(const char *ctrlgrp, const char *mongrp, int domain_id)