UPSTREAM: f2fs: fix to force buffered IO on

inline_data inode

It will return all zero data when DIO reading from inline_data inode, it
is because f2fs_iomap_begin() assign iomap->type w/ IOMAP_HOLE incorrectly
for this case.

We can let iomap framework handle inline data via assigning iomap->type
and iomap->inline_data correctly, however, it will be a little bit
complicated when handling race case in between direct IO and buffered IO.

So, let's force to use buffered IO to fix this issue.

Cc: stable@vger.kernel.org
Reported-by: Barry Song <v-songbaohua@oppo.com>
Signed-off-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

bug: 351307890
(cherry picked from commit 5c8764f867)
Change-Id: I99b94f938a6f733dabc8f42ce2f0834c133805fc
Signed-off-by: Huzhanyuan <huzhanyuan@oppo.com>
This commit is contained in:
huzhanyuan 2024-07-05 19:30:21 +08:00 committed by Treehugger Robot
parent 3efb7c2d2a
commit c867ece908

View File

@ -830,6 +830,8 @@ static bool f2fs_force_buffered_io(struct inode *inode, int rw)
return true; return true;
if (f2fs_compressed_file(inode)) if (f2fs_compressed_file(inode))
return true; return true;
if (f2fs_has_inline_data(inode))
return true;
/* disallow direct IO if any of devices has unaligned blksize */ /* disallow direct IO if any of devices has unaligned blksize */
if (f2fs_is_multi_device(sbi) && !sbi->aligned_blksize) if (f2fs_is_multi_device(sbi) && !sbi->aligned_blksize)