MIRRORS/linux-imx
1
0
Fork 0
mirror of https://github.com/nxp-imx/linux-imx.git synced 2025-07-08 10:25:20 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

UPSTREAM: f2fs: Create COW inode from parent dentry for atomic write

Browse Source 
The i_pino in f2fs_inode_info has the previous parent's i_ino when inode
was renamed, which may cause f2fs_ioc_start_atomic_write to fail.
If file_wrong_pino is true and i_nlink is 1, then to find a valid pino,
we should refer to the dentry from inode.

To resolve this issue, let's get parent inode using parent dentry
directly.

Fixes: 3db1de0e58 ("f2fs: change the current atomic write way")
Reviewed-by: Sungjong Seo <sj1557.seo@samsung.com>
Reviewed-by: Sunmin Jeong <s_min.jeong@samsung.com>
Change-Id: Icd55d02039f35dcce4292259eafaa4fa83f0867c
Signed-off-by: Yeongjin Gil <youngjin.gil@samsung.com>
Reviewed-by: Daeho Jeong <daehojeong@google.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
(cherry picked from commit 8c1b787938)
This commit is contained in:
Yeongjin Gil 2024-08-13 16:32:44 +09:00 committed by Matthias Männich
parent 3e77e46479
commit ca6dd95d54
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
fs/f2fs/file.c
View File

@ -2134,7 +2134,6 @@ static int f2fs_ioc_start_atomic_write(struct file *filp, bool truncate)
struct mnt_idmap *idmap = file_mnt_idmap(filp); struct mnt_idmap *idmap = file_mnt_idmap(filp);
struct f2fs_inode_info *fi = F2FS_I(inode); struct f2fs_inode_info *fi = F2FS_I(inode);
struct f2fs_sb_info *sbi = F2FS_I_SB(inode); struct f2fs_sb_info *sbi = F2FS_I_SB(inode);
struct inode *pinode;
loff_t isize; loff_t isize;
int ret; int ret;
@ -2187,15 +2186,10 @@ static int f2fs_ioc_start_atomic_write(struct file *filp, bool truncate)
/* Check if the inode already has a COW inode */ /* Check if the inode already has a COW inode */
if (fi->cow_inode == NULL) { if (fi->cow_inode == NULL) {
/* Create a COW inode for atomic write */ /* Create a COW inode for atomic write */
pinode = f2fs_iget(inode->i_sb, fi->i_pino); struct dentry *dentry = file_dentry(filp);
if (IS_ERR(pinode)) { struct inode *dir = d_inode(dentry->d_parent);
f2fs_up_write(&fi->i_gc_rwsem[WRITE]);
ret = PTR_ERR(pinode);
goto out;
}
ret = f2fs_get_tmpfile(idmap, pinode, &fi->cow_inode); ret = f2fs_get_tmpfile(idmap, dir, &fi->cow_inode);
iput(pinode);
if (ret) { if (ret) {
f2fs_up_write(&fi->i_gc_rwsem[WRITE]); f2fs_up_write(&fi->i_gc_rwsem[WRITE]);
goto out; goto out;