bpf: Add cookie to perf_event bpf_link_info records

[ Upstream commit d5c16492c6 ]

At the moment we don't store cookie for perf_event probes,
while we do that for the rest of the probes.

Adding cookie fields to struct bpf_link_info perf event
probe records:

  perf_event.uprobe
  perf_event.kprobe
  perf_event.tracepoint
  perf_event.perf_event

And the code to store that in bpf_link_info struct.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: Song Liu <song@kernel.org>
Acked-by: Yafang Shao <laoar.shao@gmail.com>
Link: https://lore.kernel.org/r/20240119110505.400573-2-jolsa@kernel.org
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Stable-dep-of: 4deecdd29c ("bpf: fix unpopulated name_len field in perf_event link info")
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Jiri Olsa 2024-01-19 12:04:58 +01:00 committed by Greg Kroah-Hartman
parent 99bf10e92a
commit cfd63c3a45
3 changed files with 16 additions and 0 deletions

View File

@ -6556,6 +6556,7 @@ struct bpf_link_info {
__aligned_u64 file_name; /* in/out */ __aligned_u64 file_name; /* in/out */
__u32 name_len; __u32 name_len;
__u32 offset; /* offset from file_name */ __u32 offset; /* offset from file_name */
__u64 cookie;
} uprobe; /* BPF_PERF_EVENT_UPROBE, BPF_PERF_EVENT_URETPROBE */ } uprobe; /* BPF_PERF_EVENT_UPROBE, BPF_PERF_EVENT_URETPROBE */
struct { struct {
__aligned_u64 func_name; /* in/out */ __aligned_u64 func_name; /* in/out */
@ -6563,14 +6564,19 @@ struct bpf_link_info {
__u32 offset; /* offset from func_name */ __u32 offset; /* offset from func_name */
__u64 addr; __u64 addr;
__u64 missed; __u64 missed;
__u64 cookie;
} kprobe; /* BPF_PERF_EVENT_KPROBE, BPF_PERF_EVENT_KRETPROBE */ } kprobe; /* BPF_PERF_EVENT_KPROBE, BPF_PERF_EVENT_KRETPROBE */
struct { struct {
__aligned_u64 tp_name; /* in/out */ __aligned_u64 tp_name; /* in/out */
__u32 name_len; __u32 name_len;
__u32 :32;
__u64 cookie;
} tracepoint; /* BPF_PERF_EVENT_TRACEPOINT */ } tracepoint; /* BPF_PERF_EVENT_TRACEPOINT */
struct { struct {
__u64 config; __u64 config;
__u32 type; __u32 type;
__u32 :32;
__u64 cookie;
} event; /* BPF_PERF_EVENT_EVENT */ } event; /* BPF_PERF_EVENT_EVENT */
}; };
} perf_event; } perf_event;

View File

@ -3500,6 +3500,7 @@ static int bpf_perf_link_fill_kprobe(const struct perf_event *event,
if (!kallsyms_show_value(current_cred())) if (!kallsyms_show_value(current_cred()))
addr = 0; addr = 0;
info->perf_event.kprobe.addr = addr; info->perf_event.kprobe.addr = addr;
info->perf_event.kprobe.cookie = event->bpf_cookie;
return 0; return 0;
} }
#endif #endif
@ -3525,6 +3526,7 @@ static int bpf_perf_link_fill_uprobe(const struct perf_event *event,
else else
info->perf_event.type = BPF_PERF_EVENT_UPROBE; info->perf_event.type = BPF_PERF_EVENT_UPROBE;
info->perf_event.uprobe.offset = offset; info->perf_event.uprobe.offset = offset;
info->perf_event.uprobe.cookie = event->bpf_cookie;
return 0; return 0;
} }
#endif #endif
@ -3552,6 +3554,7 @@ static int bpf_perf_link_fill_tracepoint(const struct perf_event *event,
uname = u64_to_user_ptr(info->perf_event.tracepoint.tp_name); uname = u64_to_user_ptr(info->perf_event.tracepoint.tp_name);
ulen = info->perf_event.tracepoint.name_len; ulen = info->perf_event.tracepoint.name_len;
info->perf_event.type = BPF_PERF_EVENT_TRACEPOINT; info->perf_event.type = BPF_PERF_EVENT_TRACEPOINT;
info->perf_event.tracepoint.cookie = event->bpf_cookie;
return bpf_perf_link_fill_common(event, uname, ulen, NULL, NULL, NULL, NULL); return bpf_perf_link_fill_common(event, uname, ulen, NULL, NULL, NULL, NULL);
} }
@ -3560,6 +3563,7 @@ static int bpf_perf_link_fill_perf_event(const struct perf_event *event,
{ {
info->perf_event.event.type = event->attr.type; info->perf_event.event.type = event->attr.type;
info->perf_event.event.config = event->attr.config; info->perf_event.event.config = event->attr.config;
info->perf_event.event.cookie = event->bpf_cookie;
info->perf_event.type = BPF_PERF_EVENT_EVENT; info->perf_event.type = BPF_PERF_EVENT_EVENT;
return 0; return 0;
} }

View File

@ -6559,6 +6559,7 @@ struct bpf_link_info {
__aligned_u64 file_name; /* in/out */ __aligned_u64 file_name; /* in/out */
__u32 name_len; __u32 name_len;
__u32 offset; /* offset from file_name */ __u32 offset; /* offset from file_name */
__u64 cookie;
} uprobe; /* BPF_PERF_EVENT_UPROBE, BPF_PERF_EVENT_URETPROBE */ } uprobe; /* BPF_PERF_EVENT_UPROBE, BPF_PERF_EVENT_URETPROBE */
struct { struct {
__aligned_u64 func_name; /* in/out */ __aligned_u64 func_name; /* in/out */
@ -6566,14 +6567,19 @@ struct bpf_link_info {
__u32 offset; /* offset from func_name */ __u32 offset; /* offset from func_name */
__u64 addr; __u64 addr;
__u64 missed; __u64 missed;
__u64 cookie;
} kprobe; /* BPF_PERF_EVENT_KPROBE, BPF_PERF_EVENT_KRETPROBE */ } kprobe; /* BPF_PERF_EVENT_KPROBE, BPF_PERF_EVENT_KRETPROBE */
struct { struct {
__aligned_u64 tp_name; /* in/out */ __aligned_u64 tp_name; /* in/out */
__u32 name_len; __u32 name_len;
__u32 :32;
__u64 cookie;
} tracepoint; /* BPF_PERF_EVENT_TRACEPOINT */ } tracepoint; /* BPF_PERF_EVENT_TRACEPOINT */
struct { struct {
__u64 config; __u64 config;
__u32 type; __u32 type;
__u32 :32;
__u64 cookie;
} event; /* BPF_PERF_EVENT_EVENT */ } event; /* BPF_PERF_EVENT_EVENT */
}; };
} perf_event; } perf_event;