MIRRORS/linux-imx
1
0
Fork 0
mirror of https://github.com/nxp-imx/linux-imx.git synced 2025-07-18 07:09:36 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

soc: qcom: pmic_glink: don't traverse clients list without a lock

Browse Source 
[ Upstream commit 635ce0db89 ]

Take the client_lock before traversing the clients list at the
pmic_glink_state_notify_clients() function. This is required to keep the
list traversal safe from concurrent modification.

Fixes: 58ef4ece1e ("soc: qcom: pmic_glink: Introduce base PMIC GLINK driver")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
Tested-by: Xilin Wu <wuxilin123@gmail.com> # on QCS8550 AYN Odin 2
Link: https://lore.kernel.org/r/20240403-pmic-glink-fix-clients-v2-1-aed4e02baacc@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Dmitry Baryshkov 2024-04-03 06:10:57 +03:00 committed by Greg Kroah-Hartman
parent 840565b135
commit d02c6eb5d3
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/soc/qcom/pmic_glink.c
View File

@ -118,10 +118,12 @@ static int pmic_glink_rpmsg_callback(struct rpmsg_device *rpdev, void *data,
hdr = data; hdr = data;
mutex_lock(&pg->client_lock);
list_for_each_entry(client, &pg->clients, node) { list_for_each_entry(client, &pg->clients, node) {
if (client->id == le32_to_cpu(hdr->owner)) if (client->id == le32_to_cpu(hdr->owner))
client->cb(data, len, client->priv); client->cb(data, len, client->priv);
} }
mutex_unlock(&pg->client_lock);
return 0; return 0;
} }
@ -171,8 +173,10 @@ static void pmic_glink_state_notify_clients(struct pmic_glink *pg)
} }
if (new_state != pg->client_state) { if (new_state != pg->client_state) {
mutex_lock(&pg->client_lock);
list_for_each_entry(client, &pg->clients, node) list_for_each_entry(client, &pg->clients, node)
client->pdr_notify(client->priv, new_state); client->pdr_notify(client->priv, new_state);
mutex_unlock(&pg->client_lock);
pg->client_state = new_state; pg->client_state = new_state;
} }
} }