mirror of
https://github.com/nxp-imx/linux-imx.git
synced 2025-10-22 23:23:03 +02:00
vduse: Temporarily fail if control queue feature requested
[ Upstream commit 56e71885b0
]
Virtio-net driver control queue implementation is not safe
when used with VDUSE. If the VDUSE application does not
reply to control queue messages, it currently ends up
hanging the kernel thread sending this command.
Some work is on-going to make the control queue
implementation robust with VDUSE. Until it is completed,
let's fail features check if control-queue feature is
requested.
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Message-Id: <20240109111025.1320976-3-maxime.coquelin@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Eugenio Pérez <eperezma@redhat.com>
Reviewed-by: Xie Yongji <xieyongji@bytedance.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
8d4d14536c
commit
df475f71d4
|
@ -8,6 +8,7 @@
|
|||
*
|
||||
*/
|
||||
|
||||
#include "linux/virtio_net.h"
|
||||
#include <linux/init.h>
|
||||
#include <linux/module.h>
|
||||
#include <linux/cdev.h>
|
||||
|
@ -28,6 +29,7 @@
|
|||
#include <uapi/linux/virtio_config.h>
|
||||
#include <uapi/linux/virtio_ids.h>
|
||||
#include <uapi/linux/virtio_blk.h>
|
||||
#include <uapi/linux/virtio_ring.h>
|
||||
#include <linux/mod_devicetable.h>
|
||||
|
||||
#include "iova_domain.h"
|
||||
|
@ -1671,6 +1673,9 @@ static bool features_is_valid(struct vduse_dev_config *config)
|
|||
if ((config->device_id == VIRTIO_ID_BLOCK) &&
|
||||
(config->features & BIT_ULL(VIRTIO_BLK_F_CONFIG_WCE)))
|
||||
return false;
|
||||
else if ((config->device_id == VIRTIO_ID_NET) &&
|
||||
(config->features & BIT_ULL(VIRTIO_NET_F_CTRL_VQ)))
|
||||
return false;
|
||||
|
||||
return true;
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue
Block a user