MIRRORS/linux-imx
1
0
Fork 0
mirror of https://github.com/nxp-imx/linux-imx.git synced 2026-04-30 16:31:46 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity
git.kernel.org/linux-stable/linux-3.12.y
linux-imx/crypto
History
Jiri Slaby 66c7dc1ef6 crypto: algif_hash - avoid zero-sized array 
commit 6207119444 upstream.

With this reproducer:
  struct sockaddr_alg alg = {
          .salg_family = 0x26,
          .salg_type = "hash",
          .salg_feat = 0xf,
          .salg_mask = 0x5,
          .salg_name = "digest_null",
  };
  int sock, sock2;

  sock = socket(AF_ALG, SOCK_SEQPACKET, 0);
  bind(sock, (struct sockaddr *)&alg, sizeof(alg));
  sock2 = accept(sock, NULL, NULL);
  setsockopt(sock, SOL_ALG, ALG_SET_KEY, "\x9b\xca", 2);
  accept(sock2, NULL, NULL);

==== 8< ======== 8< ======== 8< ======== 8< ====

one can immediatelly see an UBSAN warning:
UBSAN: Undefined behaviour in crypto/algif_hash.c:187:7
variable length array bound value 0 <= 0
CPU: 0 PID: 15949 Comm: syz-executor Tainted: G            E      4.4.30-0-default #1
...
Call Trace:
...
 [<ffffffff81d598fd>] ? __ubsan_handle_vla_bound_not_positive+0x13d/0x188
 [<ffffffff81d597c0>] ? __ubsan_handle_out_of_bounds+0x1bc/0x1bc
 [<ffffffffa0e2204d>] ? hash_accept+0x5bd/0x7d0 [algif_hash]
 [<ffffffffa0e2293f>] ? hash_accept_nokey+0x3f/0x51 [algif_hash]
 [<ffffffffa0e206b0>] ? hash_accept_parent_nokey+0x4a0/0x4a0 [algif_hash]
 [<ffffffff8235c42b>] ? SyS_accept+0x2b/0x40

It is a correct warning, as hash state is propagated to accept as zero,
but creating a zero-length variable array is not allowed in C.

Fix this as proposed by Herbert -- do "?: 1" on that site. No sizeof or
similar happens in the code there, so we just allocate one byte even
though we do not use the array.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net> (maintainer:CRYPTO API)
Reported-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
2017-04-07 10:38:28 +02:00
..
asymmetric_keys crypto: crypto_memneq - add equality testing of memory regions w/o timing leaks 2016-04-23 09:24:42 +02:00
async_tx drivers/dma: remove unused support for MEMSET operations 2013-07-03 16:07:42 -07:00
842.c crypto: prefix module autoloading with "crypto-" 2015-01-29 15:45:11 +01:00
ablkcipher.c crypto: api - Only abort operations on fatal signal 2015-11-12 14:09:02 +01:00
aead.c crypto: user - fix info leaks in report API 2013-02-19 20:27:03 +08:00
aes_generic.c crypto: add missing crypto module aliases 2015-01-29 15:45:12 +01:00
af_alg.c crypto: af_alg - Add nokey compatibility path 2016-02-24 09:24:09 +01:00
ahash.c crypto: hash - Fix page length clamping in hash walk 2016-05-16 16:29:24 +02:00
algapi.c crypto: api - Clear CRYPTO_ALG_DEAD bit before registering an alg 2017-02-16 11:44:34 +01:00
algboss.c crypto: algboss - Hold ref count on larval 2013-06-25 19:15:17 +08:00
algif_hash.c crypto: algif_hash - avoid zero-sized array 2017-04-07 10:38:28 +02:00
algif_skcipher.c crypto: algif_skcipher - Add nokey compatibility path 2016-02-24 09:24:10 +01:00
ansi_cprng.c crypto: rng - RNGs must return 0 in success case 2015-06-10 13:53:11 +02:00
anubis.c crypto: prefix module autoloading with "crypto-" 2015-01-29 15:45:11 +01:00
api.c crypto: api - Only abort operations on fatal signal 2015-11-12 14:09:02 +01:00
arc4.c crypto: prefix module autoloading with "crypto-" 2015-01-29 15:45:11 +01:00
authenc.c crypto: crypto_memneq - add equality testing of memory regions w/o timing leaks 2016-04-23 09:24:42 +02:00
authencesn.c crypto: crypto_memneq - add equality testing of memory regions w/o timing leaks 2016-04-23 09:24:42 +02:00
blkcipher.c crypto: skcipher - Fix blkcipher walk OOM crash 2016-09-29 14:42:22 +02:00
blowfish_common.c crypto: blowfish - split generic and common c code 2011-09-22 21:25:25 +10:00
blowfish_generic.c crypto: add missing crypto module aliases 2015-01-29 15:45:12 +01:00
camellia_generic.c crypto: add missing crypto module aliases 2015-01-29 15:45:12 +01:00
cast_common.c crypto: make tables used from assembler __visible 2013-08-14 20:42:03 +10:00
cast5_generic.c crypto: add missing crypto module aliases 2015-01-29 15:45:12 +01:00
cast6_generic.c crypto: add missing crypto module aliases 2015-01-29 15:45:12 +01:00
cbc.c crypto: include crypto- module prefix in template 2015-01-29 15:45:11 +01:00
ccm.c crypto: crypto_memneq - add equality testing of memory regions w/o timing leaks 2016-04-23 09:24:42 +02:00
chainiv.c crypto: include crypto- module prefix in template 2015-01-29 15:45:11 +01:00
cipher.c crypto: cipher - Fix checkpatch errors 2010-02-16 20:31:37 +08:00
cmac.c crypto: include crypto- module prefix in template 2015-01-29 15:45:11 +01:00
compress.c crypto: compress - Fix checkpatch errors 2010-02-16 20:31:04 +08:00
crc32.c crypto: prefix module autoloading with "crypto-" 2015-01-29 15:45:11 +01:00
crc32c.c crypto: crc32c - add missing crypto module alias 2015-02-10 11:08:16 +01:00
crct10dif_common.c crypto: crct10dif - Add fallback for broken initrds 2013-09-12 15:31:34 +10:00
crct10dif_generic.c crypto: add missing crypto module aliases 2015-01-29 15:45:12 +01:00
cryptd.c crypto: cryptd - Assign statesize properly 2017-04-07 09:17:44 +02:00
crypto_null.c crypto: prefix module autoloading with "crypto-" 2015-01-29 15:45:11 +01:00
crypto_user.c crypto: user - lock crypto_alg_list on alg dump 2016-02-24 09:45:12 +01:00
crypto_wq.c crypto: crypto_wq - Fix late crypto work queue initialization 2014-06-09 15:53:25 +02:00
ctr.c crypto: include crypto- module prefix in template 2015-01-29 15:45:11 +01:00
cts.c crypto: include crypto- module prefix in template 2015-01-29 15:45:11 +01:00
deflate.c crypto: prefix module autoloading with "crypto-" 2015-01-29 15:45:11 +01:00
des_generic.c crypto: add missing crypto module aliases 2015-01-29 15:45:12 +01:00
ecb.c crypto: include crypto- module prefix in template 2015-01-29 15:45:11 +01:00
eseqiv.c crypto: include crypto- module prefix in template 2015-01-29 15:45:11 +01:00
fcrypt.c crypto: prefix module autoloading with "crypto-" 2015-01-29 15:45:11 +01:00
fips.c crypto: api - Add fips_enable flag 2008-08-29 15:50:02 +10:00
gcm.c crypto: gcm - Fix IV buffer size in crypto_gcm_setkey 2016-11-08 16:38:27 +01:00
gf128mul.c crypto: gf128mul - fix call to memset() 2011-07-08 17:21:21 +08:00
ghash-generic.c crypto: add missing crypto module aliases 2015-01-29 15:45:12 +01:00
hmac.c crypto: include crypto- module prefix in template 2015-01-29 15:45:11 +01:00
internal.h crypto: algboss - Hold ref count on larval 2013-06-25 19:15:17 +08:00
Kconfig Reinstate "crypto: crct10dif - Wrap crc_t10dif function all to use crypto transform framework" 2013-09-07 12:56:26 +10:00
khazad.c crypto: prefix module autoloading with "crypto-" 2015-01-29 15:45:11 +01:00
krng.c crypto: add missing crypto module aliases 2015-01-29 15:45:12 +01:00
lrw.c crypto: include crypto- module prefix in template 2015-01-29 15:45:11 +01:00
lz4.c crypto: prefix module autoloading with "crypto-" 2015-01-29 15:45:11 +01:00
lz4hc.c crypto: prefix module autoloading with "crypto-" 2015-01-29 15:45:11 +01:00
lzo.c crypto: prefix module autoloading with "crypto-" 2015-01-29 15:45:11 +01:00
Makefile crypto: improve gcc optimization flags for serpent and wp512 2017-03-28 15:49:07 +02:00
md4.c crypto: prefix module autoloading with "crypto-" 2015-01-29 15:45:11 +01:00
md5.c crypto: prefix module autoloading with "crypto-" 2015-01-29 15:45:11 +01:00
memneq.c crypto: crypto_memneq - add equality testing of memory regions w/o timing leaks 2016-04-23 09:24:42 +02:00
michael_mic.c crypto: prefix module autoloading with "crypto-" 2015-01-29 15:45:11 +01:00
pcbc.c crypto: include crypto- module prefix in template 2015-01-29 15:45:11 +01:00
pcompress.c crypto: user - fix info leaks in report API 2013-02-19 20:27:03 +08:00
pcrypt.c crypto: include crypto- module prefix in template 2015-01-29 15:45:11 +01:00
proc.c crypto: add module.h to those files that are explicitly using it 2011-10-31 19:31:11 -04:00
ripemd.h [CRYPTO] ripemd: Put all common RIPEMD values in header file 2008-07-10 20:35:12 +08:00
rmd128.c crypto: prefix module autoloading with "crypto-" 2015-01-29 15:45:11 +01:00
rmd160.c crypto: prefix module autoloading with "crypto-" 2015-01-29 15:45:11 +01:00
rmd256.c crypto: prefix module autoloading with "crypto-" 2015-01-29 15:45:11 +01:00
rmd320.c crypto: prefix module autoloading with "crypto-" 2015-01-29 15:45:11 +01:00
rng.c crypto: user - fix info leaks in report API 2013-02-19 20:27:03 +08:00
salsa20_generic.c crypto: add missing crypto module aliases 2015-01-29 15:45:12 +01:00
scatterwalk.c crypto: scatterwalk - Fix test in scatterwalk_done 2016-08-19 09:51:08 +02:00
seed.c crypto: prefix module autoloading with "crypto-" 2015-01-29 15:45:11 +01:00
seqiv.c crypto: include crypto- module prefix in template 2015-01-29 15:45:11 +01:00
serpent_generic.c crypto: add missing crypto module aliases 2015-01-29 15:45:12 +01:00
sha1_generic.c crypto: add missing crypto module aliases 2015-01-29 15:45:12 +01:00
sha256_generic.c crypto: sha - Handle unaligned input data in generic sha256 and sha512. 2015-04-09 13:14:26 +02:00
sha512_generic.c crypto: sha - Handle unaligned input data in generic sha256 and sha512. 2015-04-09 13:14:26 +02:00
shash.c crypto: hash - Add crypto_ahash_has_setkey 2016-02-24 09:45:09 +01:00
tcrypt.c crypto: testmgr - don't use interruptible wait in tests 2015-04-09 14:13:16 +02:00
tcrypt.h crypto: ctr - make rfc3686 asynchronous block cipher 2013-01-08 07:03:04 +01:00
tea.c crypto: add missing crypto module aliases 2015-01-29 15:45:12 +01:00
testmgr.c crypto: testmgr - fix RNG return code enforcement 2015-06-10 14:05:57 +02:00
testmgr.h Reinstate "crypto: crct10dif - Wrap crc_t10dif function all to use crypto transform framework" 2013-09-07 12:56:26 +10:00
tgr192.c crypto: add missing crypto module aliases 2015-01-29 15:45:12 +01:00
twofish_common.c crypto: twofish-x86_64-3way - add lrw support 2011-11-09 11:53:32 +08:00
twofish_generic.c crypto: add missing crypto module aliases 2015-01-29 15:45:12 +01:00
vmac.c crypto: include crypto- module prefix in template 2015-01-29 15:45:11 +01:00
wp512.c crypto: add missing crypto module aliases 2015-01-29 15:45:12 +01:00
xcbc.c crypto: include crypto- module prefix in template 2015-01-29 15:45:11 +01:00
xor.c add further __init annotations to crypto/xor.c 2012-10-11 13:42:32 +11:00
xts.c crypto: include crypto- module prefix in template 2015-01-29 15:45:11 +01:00
zlib.c crypto: prefix module autoloading with "crypto-" 2015-01-29 15:45:11 +01:00