Jeremy Compostella fa05746dcb i2c: core-smbus: prevent stack corruption on read I2C_BLOCK_DATA ... commit 89c6efa61f upstream. On a I2C_SMBUS_I2C_BLOCK_DATA read request, if data->block[0] is greater than I2C_SMBUS_BLOCK_MAX + 1, the underlying I2C driver writes data out of the msgbuf1 array boundary. It is possible from a user application to run into that issue by calling the I2C_SMBUS ioctl with data.block[0] greater than I2C_SMBUS_BLOCK_MAX + 1. This patch makes the code compliant with Documentation/i2c/dev-interface by raising an error when the requested size is larger than 32 bytes. Call Trace: [<ffffffff8139f695>] dump_stack+0x67/0x92 [<ffffffff811802a4>] panic+0xc5/0x1eb [<ffffffff810ecb5f>] ? vprintk_default+0x1f/0x30 [<ffffffff817456d3>] ? i2cdev_ioctl_smbus+0x303/0x320 [<ffffffff8109a68b>] __stack_chk_fail+0x1b/0x20 [<ffffffff817456d3>] i2cdev_ioctl_smbus+0x303/0x320 [<ffffffff81745aed>] i2cdev_ioctl+0x4d/0x1e0 [<ffffffff811f761a>] do_vfs_ioctl+0x2ba/0x490 [<ffffffff81336e43>] ? security_file_ioctl+0x43/0x60 [<ffffffff811f7869>] SyS_ioctl+0x79/0x90 [<ffffffff81a22e97>] entry_SYSCALL_64_fastpath+0x12/0x6a Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com> Signed-off-by: Wolfram Sang <wsa@the-dreams.de> [bwh: Backported to 3.2: adjust filename] Signed-off-by: Ben Hutchings <ben@decadent.org.uk>		2018-03-03 15:51:01 +00:00
..
algos	i2c-algo-bit: Fix spurious SCL timeouts under heavy load	2012-03-19 09:02:35 -07:00
busses	i2c: i2c-tiny-usb: fix buffer not being DMA capable	2017-09-15 18:30:46 +01:00
muxes	i2c/pca954x: Initialize the mux to disconnected state	2011-06-29 11:36:11 +02:00
i2c-boardinfo.c	i2c: add export.h to i2c-boardinfo.c for EXPORT_SYMBOL	2011-10-31 19:31:29 -04:00
i2c-core.c	i2c: core-smbus: prevent stack corruption on read I2C_BLOCK_DATA	2018-03-03 15:51:01 +00:00
i2c-core.h	i2c: Use rwsem instead of mutex for board info	2009-06-19 16:58:20 +02:00
i2c-dev.c	i2c: fix kernel memory disclosure in dev interface	2017-03-16 02:18:44 +00:00
i2c-mux.c	i2c: Mark i2c_adapter.id as deprecated	2010-11-15 22:40:38 +01:00
i2c-smbus.c	i2c: Remove all i2c_set_clientdata(client, NULL) in drivers	2010-06-03 11:33:58 +02:00
Kconfig	doc: Kconfig: Typo: square -> squared	2011-07-11 14:22:32 +02:00
Makefile	i2c: Deprecate i2c_driver.attach_adapter and .detach_adapter	2011-03-20 14:50:53 +01:00