Carlos Llamas 1f33d9f1d9 binder: fix UAF caused by offsets overwrite ... commit 4df153652c upstream. Binder objects are processed and copied individually into the target buffer during transactions. Any raw data in-between these objects is copied as well. However, this raw data copy lacks an out-of-bounds check. If the raw data exceeds the data section size then the copy overwrites the offsets section. This eventually triggers an error that attempts to unwind the processed objects. However, at this point the offsets used to index these objects are now corrupted. Unwinding with corrupted offsets can result in decrements of arbitrary nodes and lead to their premature release. Other users of such nodes are left with a dangling pointer triggering a use-after-free. This issue is made evident by the following KASAN report (trimmed): ================================================================== BUG: KASAN: slab-use-after-free in _raw_spin_lock+0xe4/0x19c Write of size 4 at addr ffff47fc91598f04 by task binder-util/743 CPU: 9 UID: 0 PID: 743 Comm: binder-util Not tainted 6.11.0-rc4 #1 Hardware name: linux,dummy-virt (DT) Call trace: _raw_spin_lock+0xe4/0x19c binder_free_buf+0x128/0x434 binder_thread_write+0x8a4/0x3260 binder_ioctl+0x18f0/0x258c [...] Allocated by task 743: __kmalloc_cache_noprof+0x110/0x270 binder_new_node+0x50/0x700 binder_transaction+0x413c/0x6da8 binder_thread_write+0x978/0x3260 binder_ioctl+0x18f0/0x258c [...] Freed by task 745: kfree+0xbc/0x208 binder_thread_read+0x1c5c/0x37d4 binder_ioctl+0x16d8/0x258c [...] ================================================================== To avoid this issue, let's check that the raw data copy is within the boundaries of the data section. Fixes: 6d98eb95b4 ("binder: avoid potential data leakage when copying txn") Cc: Todd Kjos <tkjos@google.com> Cc: stable@vger.kernel.org Signed-off-by: Carlos Llamas <cmllamas@google.com> Link: https://lore.kernel.org/r/20240822182353.2129600-1-cmllamas@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2024-09-12 11:11:41 +02:00
..
binder_alloc_selftest.c	Revert "android: binder: stop saving a pointer to the VMA"	2023-05-13 20:30:16 +09:00
binder_alloc.c	binder: fix race between mmput() and do_exit()	2024-01-25 15:35:42 -08:00
binder_alloc.h	binder: fix memory leak in binder_init()	2023-08-04 15:25:01 +02:00
binder_internal.h	binder: fix max_thread type inconsistency	2024-05-25 16:22:54 +02:00
binder_trace.h	Binder: add TF_UPDATE_TXN to replace outdated txn	2022-06-27 16:16:30 +02:00
binder.c	binder: fix UAF caused by offsets overwrite	2024-09-12 11:11:41 +02:00
binderfs.c	Char/Misc driver changes for 6.6-rc1	2023-09-01 09:53:54 -07:00
Kconfig	remove CONFIG_ANDROID	2022-07-01 10:41:09 +02:00
Makefile	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00