Chengfeng Ye e6571cff84 media: s5p-mfc: Fix potential deadlock on condlock ... [ Upstream commit 04d19e6513 ] As &dev->condlock is acquired under irq context along the following call chain from s5p_mfc_irq(), other acquisition of the same lock inside process context or softirq context should disable irq avoid double lock. enc_post_frame_start() seems to be one such function that execute under process context or softirq context. <deadlock #1> enc_post_frame_start() --> clear_work_bit() --> spin_loc(&dev->condlock) <interrupt> --> s5p_mfc_irq() --> s5p_mfc_handle_frame() --> clear_work_bit() --> spin_lock(&dev->condlock) This flaw was found by an experimental static analysis tool I am developing for irq-related deadlock. To prevent the potential deadlock, the patch change clear_work_bit() inside enc_post_frame_start() to clear_work_bit_irqsave(). Signed-off-by: Chengfeng Ye <dg573847474@gmail.com> Acked-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-08-29 17:33:26 +02:00
..
exynos-gsc	media: Explicitly include correct DT includes	2023-07-19 12:57:51 +02:00
exynos4-is	media: v4l: async: Set v4l2_device and subdev in async notifier init	2023-08-10 07:58:32 +02:00
s3c-camif	media: s3c-camif: Avoid inappropriate kfree()	2023-11-20 11:59:32 +01:00
s5p-g2d
s5p-jpeg	media: jpeg-core: Remove redundant dev_err()	2023-08-10 07:58:36 +02:00
s5p-mfc	media: s5p-mfc: Fix potential deadlock on condlock	2024-08-29 17:33:26 +02:00
Kconfig
Makefile