linux-imx/drivers/net/usb
Foster Snowhill 28123a54f8 usbnet: ipheth: fix carrier detection in modes 1 and 4
[ Upstream commit 67927a1b25 ]

Apart from the standard "configurations", "interfaces" and "alternate
interface settings" in USB, iOS devices also have a notion of
"modes". In different modes, the device exposes a different set of
available configurations.

Depending on the iOS version, and depending on the current mode, the
length and contents of the carrier state control message differs:

* 1 byte (seen on iOS 4.2.1, 8.4):
    * 03: carrier off (mode 0)
    * 04: carrier on (mode 0)
* 3 bytes (seen on iOS 10.3.4, 15.7.6):
    * 03 03 03: carrier off (mode 0)
    * 04 04 03: carrier on (mode 0)
* 4 bytes (seen on iOS 16.5, 17.6):
    * 03 03 03 00: carrier off (mode 0)
    * 04 03 03 00: carrier off (mode 1)
    * 06 03 03 00: carrier off (mode 4)
    * 04 04 03 04: carrier on (mode 0 and 1)
    * 06 04 03 04: carrier on (mode 4)

Before this change, the driver always used the first byte of the
response to determine carrier state.

From this larger sample, the first byte seems to indicate the number of
available USB configurations in the current mode (with the exception of
the default mode 0), and in some cases (namely mode 1 and 4) does not
correlate with the carrier state.

Previous logic erroneously counted `04 03 03 00` as "carrier on" and
`06 04 03 04` as "carrier off" on iOS versions that support mode 1 and
mode 4 respectively.

Only modes 0, 1 and 4 expose the USB Ethernet interfaces necessary for
the ipheth driver.

Check the second byte of the control message where possible, and fall
back to checking the first byte on older iOS versions.

Signed-off-by: Foster Snowhill <forst@pen.gy>
Tested-by: Georgi Valkov <gvalkov@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-09-18 19:24:05 +02:00
..
aqc111.c usb: aqc111: stop lying about skb->truesize 2024-06-12 11:11:51 +02:00
aqc111.h
asix_common.c
asix_devices.c
asix.h
ax88172a.c asix: Add check for usbnet_get_endpoints 2024-01-10 17:16:53 +01:00
ax88179_178a.c net: usb: ax88179_178a: improve link status logs 2024-07-05 09:33:58 +02:00
catc.c
cdc_eem.c
cdc_ether.c
cdc_mbim.c
cdc_ncm.c
cdc_subset.c
cdc-phonet.c
ch9200.c
cx82310_eth.c
dm9601.c net: usb: dm9601: fix wrong return value in dm9601_mdio_read 2024-03-06 14:48:35 +00:00
gl620a.c
hso.c
huawei_cdc_ncm.c
int51x1.c
ipheth.c usbnet: ipheth: fix carrier detection in modes 1 and 4 2024-09-18 19:24:05 +02:00
kalmia.c
kaweth.c
Kconfig
lan78xx.c net: lan78xx: fix runtime PM count underflow on link stop 2024-03-15 10:48:14 -04:00
lan78xx.h
lg-vl600.c
Makefile
mcs7830.c
net1080.c
pegasus.c net: move from strlcpy with unused retval to strscpy 2022-08-31 14:11:07 -07:00
pegasus.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
plusb.c
qmi_wwan.c net: usb: qmi_wwan: add MeiG Smart SRM825L 2024-09-08 07:54:32 +02:00
r8152.c r8152: fix the firmware doesn't work 2024-09-12 11:11:34 +02:00
r8153_ecm.c
rndis_host.c usb: rndis_host: Secure rndis_query check against int overflow 2023-01-03 09:24:41 +00:00
rtl8150.c net: usb: rtl8150 fix unintiatilzed variables in rtl8150_get_link_ksettings 2024-06-27 13:49:08 +02:00
sierra_net.c
smsc75xx.c
smsc75xx.h
smsc95xx.c net: usb: smsc95xx: fix changing LED_SEL bit value updated from EEPROM 2024-06-12 11:12:56 +02:00
smsc95xx.h
sr9700.c net: usb: sr9700: fix uninitialized variable use in sr_mdio_read 2024-08-11 12:47:26 +02:00
sr9700.h
sr9800.c sr9800: Add check for usbnet_get_endpoints 2024-03-26 18:19:38 -04:00
sr9800.h
usbnet.c usbnet: modern method to get random MAC 2024-09-12 11:11:34 +02:00
zaurus.c