Daniel Borkmann 924f7bbfc5 vxlan: Fix regression when dropping packets due to invalid src addresses ... [ Upstream commit 1cd4bc987a ] Commit f58f45c1e5 ("vxlan: drop packets from invalid src-address") has recently been added to vxlan mainly in the context of source address snooping/learning so that when it is enabled, an entry in the FDB is not being created for an invalid address for the corresponding tunnel endpoint. Before commit f58f45c1e5 vxlan was similarly behaving as geneve in that it passed through whichever macs were set in the L2 header. It turns out that this change in behavior breaks setups, for example, Cilium with netkit in L3 mode for Pods as well as tunnel mode has been passing before the change in f58f45c1e5 for both vxlan and geneve. After mentioned change it is only passing for geneve as in case of vxlan packets are dropped due to vxlan_set_mac() returning false as source and destination macs are zero which for E/W traffic via tunnel is totally fine. Fix it by only opting into the is_valid_ether_addr() check in vxlan_set_mac() when in fact source address snooping/learning is actually enabled in vxlan. This is done by moving the check into vxlan_snoop(). With this change, the Cilium connectivity test suite passes again for both tunnel flavors. Fixes: f58f45c1e5 ("vxlan: drop packets from invalid src-address") Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Cc: David Bauer <mail@david-bauer.net> Cc: Ido Schimmel <idosch@nvidia.com> Cc: Nikolay Aleksandrov <razor@blackwall.org> Cc: Martin KaFai Lau <martin.lau@kernel.org> Reviewed-by: Ido Schimmel <idosch@nvidia.com> Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org> Reviewed-by: David Bauer <mail@david-bauer.net> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-06-21 14:38:17 +02:00
..
Makefile	vxlan: mdb: Add MDB control path support	2023-03-17 08:05:49 +00:00
vxlan_core.c	vxlan: Fix regression when dropping packets due to invalid src addresses	2024-06-21 14:38:17 +02:00
vxlan_mdb.c	vxlan: Add MDB data path support	2023-03-17 08:05:50 +00:00
vxlan_multicast.c	vxlan: vni filtering support on collect metadata device	2022-03-01 08:38:02 +00:00
vxlan_private.h	vxlan: Add MDB data path support	2023-03-17 08:05:50 +00:00
vxlan_vnifilter.c	vxlan: vnifilter: Use GFP_KERNEL instead of GFP_ATOMIC	2023-08-22 10:58:45 -07:00