Harshit Mogalapalli 9a98ab01e3 platform/x86: hp-bioscfg: Fix error handling in hp_add_other_attributes() ... commit f40f939917 upstream. 'attr_name_kobj' is allocated using kzalloc, but on all the error paths it is not freed, hence we have a memory leak. Fix the error path before kobject_init_and_add() by adding kfree(). kobject_put() must be always called after passing the object to kobject_init_and_add(). Only the error path which is immediately next to kobject_init_and_add() calls kobject_put() and not any other error path after it. Fix the error handling after kobject_init_and_add() by moving the kobject_put() into the goto label err_other_attr_init that is already used by all the error paths after kobject_init_and_add(). Fixes: a34fc329b1 ("platform/x86: hp-bioscfg: bioscfg") Cc: stable@vger.kernel.org # 6.6.x: c5dbf0416000: platform/x86: hp-bioscfg: Simplify return check in hp_add_other_attributes() Cc: stable@vger.kernel.org # 6.6.x: 5736aa9537c9: platform/x86: hp-bioscfg: move mutex_lock() down in hp_add_other_attributes() Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <error27@gmail.com> Closes: https://lore.kernel.org/r/202309201412.on0VXJGo-lkp@intel.com/ Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> [ij: Added the stable dep tags] Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Link: https://lore.kernel.org/r/20231113200742.3593548-3-harshit.m.mogalapalli@oracle.com Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-12-03 07:33:08 +01:00
..
hp-bioscfg	platform/x86: hp-bioscfg: Fix error handling in hp_add_other_attributes()	2023-12-03 07:33:08 +01:00
hp_accel.c	platform/x86: hp: hp_accel: Convert to platform remove callback returning void	2023-03-07 12:20:11 +01:00
hp-wmi.c	platform/x86: hp-wmi:: Mark driver struct with __refdata to prevent section mismatch warning	2023-10-06 15:09:40 +02:00
Kconfig	platform/x86: hp-bioscfg: Makefile	2023-07-10 14:41:29 +02:00
Makefile	platform/x86: hp-bioscfg: Makefile	2023-07-10 14:41:29 +02:00
tc1100-wmi.c	platform/x86: hp: tc1100-wmi: Convert to platform remove callback returning void	2023-03-07 12:20:15 +01:00