Tyrel Datwyler 8bbe784c2f scsi: ibmvfc: Remove BUG_ON in the case of an empty event pool ... [ Upstream commit b39f2d10b8 ] In practice the driver should never send more commands than are allocated to a queue's event pool. In the unlikely event that this happens, the code asserts a BUG_ON, and in the case that the kernel is not configured to crash on panic returns a junk event pointer from the empty event list causing things to spiral from there. This BUG_ON is a historical artifact of the ibmvfc driver first being upstreamed, and it is well known now that the use of BUG_ON is bad practice except in the most unrecoverable scenario. There is nothing about this scenario that prevents the driver from recovering and carrying on. Remove the BUG_ON in question from ibmvfc_get_event() and return a NULL pointer in the case of an empty event pool. Update all call sites to ibmvfc_get_event() to check for a NULL pointer and perfrom the appropriate failure or recovery action. Signed-off-by: Tyrel Datwyler <tyreld@linux.ibm.com> Link: https://lore.kernel.org/r/20230921225435.3537728-2-tyreld@linux.ibm.com Reviewed-by: Brian King <brking@linux.vnet.ibm.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-11-28 17:19:42 +00:00
..
ibmvfc.c	scsi: ibmvfc: Remove BUG_ON in the case of an empty event pool	2023-11-28 17:19:42 +00:00
ibmvfc.h	scsi: ibmvfc: Store vhost pointer during subcrq allocation	2022-06-16 21:42:04 -04:00
ibmvscsi.c	scsi: ibmvscsi: Replace all non-returning strlcpy with strscpy	2023-05-26 13:52:18 -07:00
ibmvscsi.h
Makefile