linux-imx/drivers/soc/xilinx
Jay Buddhabhatti e44eb9d83d drivers: soc: xilinx: check return status of get_api_version()
commit 9b003e1480 upstream.

Currently return status is not getting checked for get_api_version
and because of that for x86 arch we are getting below smatch error.

    CC      drivers/soc/xilinx/zynqmp_power.o
drivers/soc/xilinx/zynqmp_power.c: In function 'zynqmp_pm_probe':
drivers/soc/xilinx/zynqmp_power.c:295:12: warning: 'pm_api_version' is
used uninitialized [-Wuninitialized]
    295 |         if (pm_api_version < ZYNQMP_PM_VERSION)
        |            ^
    CHECK   drivers/soc/xilinx/zynqmp_power.c
drivers/soc/xilinx/zynqmp_power.c:295 zynqmp_pm_probe() error:
uninitialized symbol 'pm_api_version'.

So, check return status of pm_get_api_version and return error in case
of failure to avoid checking uninitialized pm_api_version variable.

Fixes: b9b3a8be28 ("firmware: xilinx: Remove eemi ops for get_api_version")
Signed-off-by: Jay Buddhabhatti <jay.buddhabhatti@amd.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20240515112345.24673-1-jay.buddhabhatti@amd.com
Signed-off-by: Michal Simek <michal.simek@amd.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-08-03 08:54:18 +02:00
..
Kconfig drivers: soc: xilinx: add xilinx event management driver 2021-12-03 16:08:46 +01:00
Makefile soc: xilinx: Move power-domain driver to the genpd dir 2023-07-14 10:41:59 +02:00
xlnx_event_manager.c soc: xilinx: rename cpu_number1 to dummy_cpu_number 2024-08-03 08:53:26 +02:00
zynqmp_power.c drivers: soc: xilinx: check return status of get_api_version() 2024-08-03 08:54:18 +02:00