mirror of
https://github.com/nxp-imx/linux-imx.git
synced 2025-09-03 02:16:09 +02:00
dc93f0dcb4
During mt8195_afe_init_clock(), mt8195_audsys_clk_register() was called
followed by several other devm functions. At mt8195_afe_deinit_clock()
located at mt8195_afe_pcm_dev_remove(), mt8195_audsys_clk_unregister()
was called.
However, there was an issue with the order in which these functions were
called. Specifically, the remove callback of platform_driver was called
before devres released the resource, resulting in a use-after-free issue
during remove time.
At probe time, the order of calls was:
1. mt8195_audsys_clk_register
2. afe_priv->clk = devm_kcalloc
3. afe_priv->clk[i] = devm_clk_get
At remove time, the order of calls was:
1. mt8195_audsys_clk_unregister
3. free afe_priv->clk[i]
2. free afe_priv->clk
To resolve the problem, we can utilize devm_add_action_or_reset() in
mt8195_audsys_clk_register() so that the remove order can be changed to
3->2->1.
Fixes: 6746cc8582 ("ASoC: mediatek: mt8195: add platform driver")
Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20230601033318.10408-3-trevor.wu@mediatek.com
Signed-off-by: Mark Brown <broonie@kernel.org>
15 lines
325 B
C
15 lines
325 B
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* mt8195-audsys-clk.h -- Mediatek 8195 audsys clock definition
|
|
*
|
|
* Copyright (c) 2021 MediaTek Inc.
|
|
* Author: Trevor Wu <trevor.wu@mediatek.com>
|
|
*/
|
|
|
|
#ifndef _MT8195_AUDSYS_CLK_H_
|
|
#define _MT8195_AUDSYS_CLK_H_
|
|
|
|
int mt8195_audsys_clk_register(struct mtk_base_afe *afe);
|
|
|
|
#endif
|