Ido Schimmel f7c2f0e0cb mlxsw: spectrum_acl: Fix ACL scale regression and firmware errors ... [ Upstream commit 75d8d7a630 ] ACLs that reside in the algorithmic TCAM (A-TCAM) in Spectrum-2 and newer ASICs can share the same mask if their masks only differ in up to 8 consecutive bits. For example, consider the following filters: # tc filter add dev swp1 ingress pref 1 proto ip flower dst_ip 192.0.2.0/24 action drop # tc filter add dev swp1 ingress pref 1 proto ip flower dst_ip 198.51.100.128/25 action drop The second filter can use the same mask as the first (dst_ip/24) with a delta of 1 bit. However, the above only works because the two filters have different values in the common unmasked part (dst_ip/24). When entries have the same value in the common unmasked part they create undesired collisions in the device since many entries now have the same key. This leads to firmware errors such as [1] and to a reduced scale. Fix by adjusting the hash table key to only include the value in the common unmasked part. That is, without including the delta bits. That way the driver will detect the collision during filter insertion and spill the filter into the circuit TCAM (C-TCAM). Add a test case that fails without the fix and adjust existing cases that check C-TCAM spillage according to the above limitation. [1] mlxsw_spectrum2 0000:06:00.0: EMAD reg access failed (tid=3379b18a00003394,reg_id=3027(ptce3),type=write,status=8(resource not available)) Fixes: c22291f7cf ("mlxsw: spectrum: acl: Implement delta for ERP") Reported-by: Alexander Zubkov <green@qrator.net> Signed-off-by: Ido Schimmel <idosch@nvidia.com> Reviewed-by: Amit Cohen <amcohen@nvidia.com> Tested-by: Alexander Zubkov <green@qrator.net> Signed-off-by: Petr Machata <petrm@nvidia.com> Reviewed-by: Simon Horman <horms@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-08-03 08:53:38 +02:00
..
dma-buf	selftests: drivers: Fix incorrect kernel headers search path	2023-02-13 09:09:44 -07:00
gpu	selftests/drivers/gpu: Add error messages to drm_mm.sh	2022-06-28 13:32:29 -06:00
net	mlxsw: spectrum_acl: Fix ACL scale regression and firmware errors	2024-08-03 08:53:38 +02:00
s390x/uvdevice	selftests: drivers: Fix incorrect kernel headers search path	2023-02-13 09:09:44 -07:00
sdsi	selftests: sdsi: test sysfs setup	2022-03-02 14:56:12 +01:00
usb/usbip
.gitignore	selftests: drivers/s390x: Add uvdevice tests	2022-05-20 16:38:42 +02:00