Jason Gunthorpe b547cab1eb iommufd: Do not allow creating areas without READ or WRITE ... commit 996dc53ac2 upstream. This results in passing 0 or just IOMMU_CACHE to iommu_map(). Most of the page table formats don't like this: amdv1 - -EINVAL armv7s - returns 0, doesn't update mapped arm-lpae - returns 0 doesn't update mapped dart - returns 0, doesn't update mapped VT-D - returns -EINVAL Unfortunately the three formats that return 0 cause serious problems: - Returning ret = but not uppdating mapped from domain->map_pages() causes an infinite loop in __iommu_map() - Not writing ioptes means that VFIO/iommufd have no way to recover them and we will have memory leaks and worse during unmap Since almost nothing can support this, and it is a useless thing to do, block it early in iommufd. Cc: stable@kernel.org Fixes: aad37e71d5 ("iommufd: IOCTLs for the io_pagetable") Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> Reviewed-by: Nicolin Chen <nicolinc@nvidia.com> Reviewed-by: Kevin Tian <kevin.tian@intel.com> Link: https://lore.kernel.org/r/1-v1-1211e1294c27+4b1-iommu_no_prot_jgg@nvidia.com Signed-off-by: Joerg Roedel <jroedel@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2024-09-04 13:28:24 +02:00
..
.gitignore
config	selftests/iommu: fix the config fragment	2024-03-01 13:35:10 +01:00
iommufd_fail_nth.c	iommufd/selftest: Add coverage for IOMMU_GET_HW_INFO ioctl	2023-08-18 12:52:15 -03:00
iommufd_utils.h	iommufd/selftest: Add coverage for IOMMU_GET_HW_INFO ioctl	2023-08-18 12:52:15 -03:00
iommufd.c	iommufd: Do not allow creating areas without READ or WRITE	2024-09-04 13:28:24 +02:00
Makefile	selftests: iommu: Use installed kernel headers search path	2023-02-13 09:09:46 -07:00