John Stultz dce583c5bd selftests: timers: Fix valid-adjtimex signed left-shift undefined behavior ... [ Upstream commit 0763613621 ] The struct adjtimex freq field takes a signed value who's units are in shifted (<<16) parts-per-million. Unfortunately for negative adjustments, the straightforward use of: freq = ppm << 16 trips undefined behavior warnings with clang: valid-adjtimex.c:66:6: warning: shifting a negative signed value is undefined [-Wshift-negative-value] -499<<16, ~~~~^ valid-adjtimex.c:67:6: warning: shifting a negative signed value is undefined [-Wshift-negative-value] -450<<16, ~~~~^ .. Fix it by using a multiply by (1 << 16) instead of shifting negative values in the valid-adjtimex test case. Align the values for better readability. Reported-by: Lee Jones <joneslee@google.com> Reported-by: Muhammad Usama Anjum <usama.anjum@collabora.com> Signed-off-by: John Stultz <jstultz@google.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com> Link: https://lore.kernel.org/r/20240409202222.2830476-1-jstultz@google.com Link: https://lore.kernel.org/lkml/0c6d4f0d-2064-4444-986b-1d1ed782135f@collabora.com/ Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-05-17 12:02:16 +02:00
..
.gitignore
adjtick.c	selftests: timers: fix declarations of main()	2022-07-14 14:36:07 -06:00
alarmtimer-suspend.c	selftests:timers: globals don't need initialization to 0	2022-07-03 13:26:45 -06:00
change_skew.c	selftests: timers: fix declarations of main()	2022-07-14 14:36:07 -06:00
clocksource-switch.c	selftests: timers: clocksource-switch: adapt to kselftest framework	2022-07-14 14:36:52 -06:00
freq-step.c
inconsistency-check.c	selftests: timers: inconsistency-check: adapt to kselftest framework	2022-07-14 14:36:18 -06:00
leap-a-day.c
leapcrash.c
Makefile
mqueue-lat.c
nanosleep.c	selftests: timers: nanosleep: adapt to kselftest framework	2022-07-14 14:36:13 -06:00
nsleep-lat.c
posix_timers.c	selftests: timers: Fix posix_timers ksft_print_msg() warning	2024-04-27 17:11:30 +02:00
raw_skew.c	tools: timers: fix freq average calculation	2023-07-13 13:32:36 -06:00
rtcpie.c
set-2038.c
set-tai.c
set-timer-lat.c
set-tz.c
settings
skew_consistency.c	selftests: timers: fix declarations of main()	2022-07-14 14:36:07 -06:00
threadtest.c
valid-adjtimex.c	selftests: timers: Fix valid-adjtimex signed left-shift undefined behavior	2024-05-17 12:02:16 +02:00