Fedor Pchelkin 5c0392fdaf apparmor: avoid crash when parsed profile name is empty ... [ Upstream commit 55a8210c9e ] When processing a packed profile in unpack_profile() described like "profile :ns::samba-dcerpcd /usr/lib*/samba/{,samba/}samba-dcerpcd {...}" a string ":samba-dcerpcd" is unpacked as a fully-qualified name and then passed to aa_splitn_fqname(). aa_splitn_fqname() treats ":samba-dcerpcd" as only containing a namespace. Thus it returns NULL for tmpname, meanwhile tmpns is non-NULL. Later aa_alloc_profile() crashes as the new profile name is NULL now. general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] PREEMPT SMP KASAN NOPTI KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007] CPU: 6 PID: 1657 Comm: apparmor_parser Not tainted 6.7.0-rc2-dirty #16 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.16.2-3-gd478f380-rebuilt.opensuse.org 04/01/2014 RIP: 0010:strlen+0x1e/0xa0 Call Trace: <TASK> ? strlen+0x1e/0xa0 aa_policy_init+0x1bb/0x230 aa_alloc_profile+0xb1/0x480 unpack_profile+0x3bc/0x4960 aa_unpack+0x309/0x15e0 aa_replace_profiles+0x213/0x33c0 policy_update+0x261/0x370 profile_replace+0x20e/0x2a0 vfs_write+0x2af/0xe00 ksys_write+0x126/0x250 do_syscall_64+0x46/0xf0 entry_SYSCALL_64_after_hwframe+0x6e/0x76 </TASK> ---[ end trace 0000000000000000 ]--- RIP: 0010:strlen+0x1e/0xa0 It seems such behaviour of aa_splitn_fqname() is expected and checked in other places where it is called (e.g. aa_remove_profiles). Well, there is an explicit comment "a ns name without a following profile is allowed" inside. AFAICS, nothing can prevent unpacked "name" to be in form like ":samba-dcerpcd" - it is passed from userspace. Deny the whole profile set replacement in such case and inform user with EPROTO and an explaining message. Found by Linux Verification Center (linuxtesting.org). Fixes: 04dc715e24 ("apparmor: audit policy ns specified in policy load") Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru> Signed-off-by: John Johansen <john.johansen@canonical.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-01-25 15:35:54 -08:00
..
apparmor	apparmor: avoid crash when parsed profile name is empty	2024-01-25 15:35:54 -08:00
bpf
integrity	ima: detect changes to the backing overlay file	2023-11-28 17:20:03 +00:00
keys	KEYS: encrypted: Add check for strsep	2024-01-25 15:35:14 -08:00
landlock	landlock: Annotate struct landlock_rule with __counted_by	2023-08-18 11:44:42 +02:00
loadpin	LoadPin: Annotate struct dm_verity_loadpin_trusted_root_digest with __counted_by	2023-08-25 16:07:30 -07:00
lockdown
safesetid
selinux	selinux: Fix error priority for bind with AF_UNSPEC on PF_INET6 socket	2024-01-25 15:35:15 -08:00
smack	Smack updates for v6.6. Two minor fixes.	2023-08-30 09:28:07 -07:00
tomoyo	tomoyo: remove unused function declaration	2023-08-13 22:07:15 +09:00
yama
commoncap.c	lsm: constify the 'target' parameter in security_capget()	2023-08-08 16:48:47 -04:00
device_cgroup.c
inode.c	security: convert to ctime accessor functions	2023-07-24 10:30:08 +02:00
Kconfig
Kconfig.hardening	hardening: Move BUG_ON_DATA_CORRUPTION to hardening options	2023-08-15 14:57:25 -07:00
lsm_audit.c
Makefile
min_addr.c
security.c	lsm/stable-6.6 PR 20230829	2023-08-30 09:07:09 -07:00