Christian Marangi 0eb1002506 leds: trigger: netdev: Move size check in set_device_name ... commit 259e33cbb1 upstream. GCC 13.2 complains about array subscript 17 is above array bounds of 'char[16]' with IFNAMSIZ set to 16. The warning is correct but this scenario is impossible. set_device_name is called by device_name_store (store sysfs entry) and netdev_trig_activate. device_name_store already check if size is >= of IFNAMSIZ and return -EINVAL. (making the warning scenario impossible) netdev_trig_activate works on already defined interface, where the name has already been checked and should already follow the condition of strlen() < IFNAMSIZ. Aside from the scenario being impossible, set_device_name can be improved to both mute the warning and make the function safer. To make it safer, move size check from device_name_store directly to set_device_name and prevent any out of bounds scenario. Cc: stable@vger.kernel.org Fixes: 28a6a2ef18 ("leds: trigger: netdev: refactor code setting device name") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202309192035.GTJEEbem-lkp@intel.com/ Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> Link: https://lore.kernel.org/r/20231007131042.15032-1-ansuelsmth@gmail.com Signed-off-by: Lee Jones <lee@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-11-28 17:20:03 +00:00
..
Kconfig	leds: Mark GPIO LED trigger broken	2023-03-16 15:08:44 +00:00
ledtrig-activity.c	treewide: Convert del_timer*() to timer_shutdown*()	2022-12-25 13:38:09 -08:00
ledtrig-audio.c
ledtrig-backlight.c
ledtrig-camera.c
ledtrig-cpu.c	leds: trigger: ledtrig-cpu:: Fix 'output may be truncated' issue for 'cpu'	2023-11-20 11:59:24 +01:00
ledtrig-default-on.c
ledtrig-disk.c	leds: Change led_trigger_blink[_oneshot]() delay parameters to pass-by-value	2023-05-25 12:16:27 +01:00
ledtrig-gpio.c
ledtrig-heartbeat.c	treewide: Convert del_timer*() to timer_shutdown*()	2022-12-25 13:38:09 -08:00
ledtrig-mtd.c	leds: Change led_trigger_blink[_oneshot]() delay parameters to pass-by-value	2023-05-25 12:16:27 +01:00
ledtrig-netdev.c	leds: trigger: netdev: Move size check in set_device_name	2023-11-28 17:20:03 +00:00
ledtrig-oneshot.c
ledtrig-panic.c
ledtrig-pattern.c	treewide: Convert del_timer*() to timer_shutdown*()	2022-12-25 13:38:09 -08:00
ledtrig-timer.c
ledtrig-transient.c	treewide: Convert del_timer*() to timer_shutdown*()	2022-12-25 13:38:09 -08:00
ledtrig-tty.c	leds: trigger: tty: Do not use LED_ON/OFF constants, use led_blink_set_oneshot instead	2023-08-17 11:58:32 +01:00
Makefile