Erick Archer 58405d6eff sctp: prefer struct_size over open coded arithmetic ... [ Upstream commit e5c5f3596d ] This is an effort to get rid of all multiplications from allocation functions in order to prevent integer overflows [1][2]. As the "ids" variable is a pointer to "struct sctp_assoc_ids" and this structure ends in a flexible array: struct sctp_assoc_ids { [...] sctp_assoc_t gaids_assoc_id[]; }; the preferred way in the kernel is to use the struct_size() helper to do the arithmetic instead of the calculation "size + size * count" in the kmalloc() function. Also, refactor the code adding the "ids_size" variable to avoid sizing twice. This way, the code is more readable and safer. This code was detected with the help of Coccinelle, and audited and modified manually. Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments [1] Link: https://github.com/KSPP/linux/issues/160 [2] Signed-off-by: Erick Archer <erick.archer@outlook.com> Acked-by: Xin Long <lucien.xin@gmail.com> Reviewed-by: Kees Cook <keescook@chromium.org> Link: https://lore.kernel.org/r/PAXPR02MB724871DB78375AB06B5171C88B152@PAXPR02MB7248.eurprd02.prod.outlook.com Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-07-11 12:49:06 +02:00
..
associola.c	sctp: update transport state when processing a dupcook packet	2023-10-04 17:29:44 -07:00
auth.c
bind_addr.c
chunk.c
debug.c
diag.c
endpointola.c
input.c	inet: move inet->recverr to inet->inet_flags	2023-08-16 11:09:17 +01:00
inqueue.c
ipv6.c
Kconfig
Makefile
objcnt.c
offload.c
output.c
outqueue.c
primitive.c
proc.c	sctp: annotate data-races around sk->sk_wmem_queued	2023-08-31 11:56:59 +02:00
protocol.c	inet: move inet->freebind to inet->inet_flags	2023-08-16 11:09:17 +01:00
sm_make_chunk.c
sm_sideeffect.c
sm_statefuns.c
sm_statetable.c
socket.c	sctp: prefer struct_size over open coded arithmetic	2024-07-11 12:49:06 +02:00
stream_interleave.c
stream_sched_fc.c
stream_sched_prio.c
stream_sched_rr.c
stream_sched.c
stream.c
sysctl.c	networking: Update to register_net_sysctl_sz	2023-08-15 15:26:18 -07:00
transport.c
tsnmap.c
ulpevent.c
ulpqueue.c