Tom Parkin 6e828dc60e l2tp: fix ICMP error handling for UDP-encap sockets ... Since commit a36e185e8c ("udp: Handle ICMP errors for tunnels with same destination port on both endpoints") UDP's handling of ICMP errors has allowed for UDP-encap tunnels to determine socket associations in scenarios where the UDP hash lookup could not. Subsequently, commit d26796ae58 ("udp: check udp sock encap_type in __udp_lib_err") subtly tweaked the approach such that UDP ICMP error handling would be skipped for any UDP socket which has encapsulation enabled. In the case of L2TP tunnel sockets using UDP-encap, this latter modification effectively broke ICMP error reporting for the L2TP control plane. To a degree this isn't catastrophic inasmuch as the L2TP control protocol defines a reliable transport on top of the underlying packet switching network which will eventually detect errors and time out. However, paying attention to the ICMP error reporting allows for more timely detection of errors in L2TP userspace, and aids in debugging connectivity issues. Reinstate ICMP error handling for UDP encap L2TP tunnels: * implement struct udp_tunnel_sock_cfg .encap_err_rcv in order to allow the L2TP code to handle ICMP errors; * only implement error-handling for tunnels which have a managed socket: unmanaged tunnels using a kernel socket have no userspace to report errors back to; * flag the error on the socket, which allows for userspace to get an error such as -ECONNREFUSED back from sendmsg/recvmsg; * pass the error into ip[v6]_icmp_error() which allows for userspace to get extended error information via. MSG_ERRQUEUE. Fixes: d26796ae58 ("udp: check udp sock encap_type in __udp_lib_err") Signed-off-by: Tom Parkin <tparkin@katalix.com> Link: https://lore.kernel.org/r/20240513172248.623261-1-tparkin@katalix.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2024-05-17 12:15:22 -07:00
..
Kconfig	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
l2tp_core.c	l2tp: fix ICMP error handling for UDP-encap sockets	2024-05-17 12:15:22 -07:00
l2tp_core.h	net: ioctl: Use kernel memory on protocol ioctl callbacks	2023-06-15 22:33:26 -07:00
l2tp_debugfs.c	l2tp: l2tp_debugfs: fix Clang -Wformat warnings	2022-07-08 12:14:36 +01:00
l2tp_eth.c	net l2tp: drop flow hash on forward	2024-04-26 13:48:24 +02:00
l2tp_ip.c	inet: introduce dst_rtable() helper	2024-04-30 18:32:38 -07:00
l2tp_ip6.c	ipv6: introduce dst_rt6_info() helper	2024-04-29 13:32:01 +01:00
l2tp_netlink.c	genetlink: start to validate reserved header bytes	2022-08-29 12:47:15 +01:00
l2tp_ppp.c	l2tp: fix incorrect parameter validation in the pppol2tp_getsockopt() function	2024-03-11 09:53:22 +00:00
Makefile	l2tp: add tracepoint infrastructure to core	2020-08-22 12:44:37 -07:00
trace.h	l2tp: add tracepoint definitions in trace.h	2020-08-22 12:44:37 -07:00