mirror of
https://github.com/nxp-imx/linux-imx.git
synced 2025-07-19 07:39:54 +02:00
eff65ee26e
Running shellcheck on record_sideband.sh throws below
warning:
In tests/shell/record_sideband.sh line 25:
if ! perf record -o ${perfdata} -BN --no-bpf-event -C $1 true 2>&1 >/dev/null
^--^ SC2069: To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify).
This shows shellcheck warning SC2069 where the redirection
order needs to be fixed. Use "cmd > /dev/null 2>&1" to fix
the redirection of perf record output
Fixes: 23b97c7ee9 ("perf test: Add test case for record sideband events")
Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Reviewed-by: Kajol Jain <kjain@linux.ibm.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: disgoel@linux.vnet.ibm.com
Link: https://lore.kernel.org/r/20231013073021.99794-3-atrajeev@linux.vnet.ibm.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
59 lines
1.1 KiB
Bash
Executable File
59 lines
1.1 KiB
Bash
Executable File
#!/bin/sh
|
|
# perf record sideband tests
|
|
# SPDX-License-Identifier: GPL-2.0
|
|
|
|
set -e
|
|
|
|
err=0
|
|
perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
|
|
|
|
cleanup()
|
|
{
|
|
rm -rf ${perfdata}
|
|
trap - EXIT TERM INT
|
|
}
|
|
|
|
trap_cleanup()
|
|
{
|
|
cleanup
|
|
exit 1
|
|
}
|
|
trap trap_cleanup EXIT TERM INT
|
|
|
|
can_cpu_wide()
|
|
{
|
|
if ! perf record -o ${perfdata} -BN --no-bpf-event -C $1 true > /dev/null 2>&1
|
|
then
|
|
echo "record sideband test [Skipped cannot record cpu$1]"
|
|
err=2
|
|
fi
|
|
|
|
rm -f ${perfdata}
|
|
return $err
|
|
}
|
|
|
|
test_system_wide_tracking()
|
|
{
|
|
# Need CPU 0 and CPU 1
|
|
can_cpu_wide 0 || return 0
|
|
can_cpu_wide 1 || return 0
|
|
|
|
# Record on CPU 0 a task running on CPU 1
|
|
perf record -BN --no-bpf-event -o ${perfdata} -C 0 -- taskset --cpu-list 1 true
|
|
|
|
# Should get MMAP events from CPU 1
|
|
mmap_cnt=`perf script -i ${perfdata} --show-mmap-events -C 1 2>/dev/null | grep MMAP | wc -l`
|
|
|
|
if [ ${mmap_cnt} -gt 0 ] ; then
|
|
return 0
|
|
fi
|
|
|
|
echo "Failed to record MMAP events on CPU 1 when tracing CPU 0"
|
|
return 1
|
|
}
|
|
|
|
test_system_wide_tracking
|
|
|
|
cleanup
|
|
exit $err
|