Dave Airlie ce51369287 nouveau/vmm: don't set addr on the fail path to avoid warning ... commit cacea81390 upstream. nvif_vmm_put gets called if addr is set, but if the allocation fails we don't need to call put, otherwise we get a warning like [523232.435671] ------------[ cut here ]------------ [523232.435674] WARNING: CPU: 8 PID: 1505697 at drivers/gpu/drm/nouveau/nvif/vmm.c:68 nvif_vmm_put+0x72/0x80 [nouveau] [523232.435795] Modules linked in: uinput rfcomm snd_seq_dummy snd_hrtimer nf_conntrack_netbios_ns nf_conntrack_broadcast nft_fib_inet nft_fib_ipv4 nft_fib_ipv6 nft_fib nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 ip_set nf_tables nfnetlink qrtr bnep sunrpc binfmt_misc intel_rapl_msr intel_rapl_common intel_uncore_frequency intel_uncore_frequency_common isst_if_common iwlmvm nfit libnvdimm vfat fat x86_pkg_temp_thermal intel_powerclamp mac80211 snd_soc_avs snd_soc_hda_codec coretemp snd_hda_ext_core snd_soc_core snd_hda_codec_realtek kvm_intel snd_hda_codec_hdmi snd_compress snd_hda_codec_generic ac97_bus snd_pcm_dmaengine snd_hda_intel libarc4 snd_intel_dspcfg snd_intel_sdw_acpi snd_hda_codec kvm iwlwifi snd_hda_core btusb snd_hwdep btrtl snd_seq btintel irqbypass btbcm rapl snd_seq_device eeepc_wmi btmtk intel_cstate iTCO_wdt cfg80211 snd_pcm asus_wmi bluetooth intel_pmc_bxt iTCO_vendor_support snd_timer ledtrig_audio pktcdvd snd mei_me [523232.435828] sparse_keymap intel_uncore i2c_i801 platform_profile wmi_bmof mei pcspkr ioatdma soundcore i2c_smbus rfkill idma64 dca joydev acpi_tad loop zram nouveau drm_ttm_helper ttm video drm_exec drm_gpuvm gpu_sched crct10dif_pclmul i2c_algo_bit nvme crc32_pclmul crc32c_intel drm_display_helper polyval_clmulni nvme_core polyval_generic e1000e mxm_wmi cec ghash_clmulni_intel r8169 sha512_ssse3 nvme_common wmi pinctrl_sunrisepoint uas usb_storage ip6_tables ip_tables fuse [523232.435849] CPU: 8 PID: 1505697 Comm: gnome-shell Tainted: G W 6.6.0-rc7-nvk-uapi+ #12 [523232.435851] Hardware name: System manufacturer System Product Name/ROG STRIX X299-E GAMING II, BIOS 1301 09/24/2021 [523232.435852] RIP: 0010:nvif_vmm_put+0x72/0x80 [nouveau] [523232.435934] Code: 00 00 48 89 e2 be 02 00 00 00 48 c7 04 24 00 00 00 00 48 89 44 24 08 e8 fc bf ff ff 85 c0 75 0a 48 c7 43 08 00 00 00 00 eb b3 <0f> 0b eb f2 e8 f5 c9 b2 e6 0f 1f 44 00 00 90 90 90 90 90 90 90 90 [523232.435936] RSP: 0018:ffffc900077ffbd8 EFLAGS: 00010282 [523232.435937] RAX: 00000000fffffffe RBX: ffffc900077ffc00 RCX: 0000000000000010 [523232.435938] RDX: 0000000000000010 RSI: ffffc900077ffb38 RDI: ffffc900077ffbd8 [523232.435940] RBP: ffff888e1c4f2140 R08: 0000000000000000 R09: 0000000000000000 [523232.435940] R10: 0000000000000000 R11: 0000000000000000 R12: ffff888503811800 [523232.435941] R13: ffffc900077ffca0 R14: ffff888e1c4f2140 R15: ffff88810317e1e0 [523232.435942] FS: 00007f933a769640(0000) GS:ffff88905fa00000(0000) knlGS:0000000000000000 [523232.435943] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [523232.435944] CR2: 00007f930bef7000 CR3: 00000005d0322001 CR4: 00000000003706e0 [523232.435945] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [523232.435946] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [523232.435964] Call Trace: [523232.435965] <TASK> [523232.435966] ? nvif_vmm_put+0x72/0x80 [nouveau] [523232.436051] ? __warn+0x81/0x130 [523232.436055] ? nvif_vmm_put+0x72/0x80 [nouveau] [523232.436138] ? report_bug+0x171/0x1a0 [523232.436142] ? handle_bug+0x3c/0x80 [523232.436144] ? exc_invalid_op+0x17/0x70 [523232.436145] ? asm_exc_invalid_op+0x1a/0x20 [523232.436149] ? nvif_vmm_put+0x72/0x80 [nouveau] [523232.436230] ? nvif_vmm_put+0x64/0x80 [nouveau] [523232.436342] nouveau_vma_del+0x80/0xd0 [nouveau] [523232.436506] nouveau_vma_new+0x1a0/0x210 [nouveau] [523232.436671] nouveau_gem_object_open+0x1d0/0x1f0 [nouveau] [523232.436835] drm_gem_handle_create_tail+0xd1/0x180 [523232.436840] drm_prime_fd_to_handle_ioctl+0x12e/0x200 [523232.436844] ? __pfx_drm_prime_fd_to_handle_ioctl+0x10/0x10 [523232.436847] drm_ioctl_kernel+0xd3/0x180 [523232.436849] drm_ioctl+0x26d/0x4b0 [523232.436851] ? __pfx_drm_prime_fd_to_handle_ioctl+0x10/0x10 [523232.436855] nouveau_drm_ioctl+0x5a/0xb0 [nouveau] [523232.437032] __x64_sys_ioctl+0x94/0xd0 [523232.437036] do_syscall_64+0x5d/0x90 [523232.437040] ? syscall_exit_to_user_mode+0x2b/0x40 [523232.437044] ? do_syscall_64+0x6c/0x90 [523232.437046] entry_SYSCALL_64_after_hwframe+0x6e/0xd8 Reported-by: Faith Ekstrand <faith.ekstrand@collabora.com> Cc: stable@vger.kernel.org Signed-off-by: Dave Airlie <airlied@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240117213852.295565-1-airlied@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2024-01-31 16:18:56 -08:00
..
accel	accel/habanalabs: fix information leak in sec_attest_info()	2024-01-25 15:35:38 -08:00
accessibility
acpi	acpi: property: Let args be NULL in __acpi_node_get_property_reference	2024-01-25 15:35:51 -08:00
amba
android	binder: fix race between mmput() and do_exit()	2024-01-25 15:35:42 -08:00
ata	scsi: sd: Fix system start for ATA devices	2023-12-08 08:52:17 +01:00
atm	atm: solos-pci: Fix potential deadlock on &tx_queue_lock	2023-12-20 17:01:46 +01:00
auxdisplay
base	rtc: Extend timeout for waiting for UIP to clear to 1s	2024-01-31 16:18:56 -08:00
bcma
block	nbd: always initialize struct msghdr completely	2024-01-31 16:18:52 -08:00
bluetooth	Bluetooth: btmtkuart: fix recv_buf() return value	2024-01-25 15:35:29 -08:00
bus	bus: mhi: host: Add spinlock to protect WP access when queueing TREs	2024-01-31 16:18:52 -08:00
cache
cdrom
cdx
char	hwrng: core - Fix page fault dead lock on mmap-ed hwrng	2024-01-31 16:18:50 -08:00
clk	clk: qcom: dispcc-sm8550: Update disp PLL settings	2024-01-25 15:35:38 -08:00
clocksource	clocksource/drivers/timer-ti-dm: Fix make W=n kerneldoc warnings	2024-01-25 15:35:42 -08:00
comedi
connector	connector: Fix proc_event_num_listeners count not cleared	2024-01-20 11:51:47 +01:00
counter
cpufreq	cpufreq: scmi: process the result of devm_of_clk_add_hw_provider()	2024-01-25 15:35:14 -08:00
cpuidle	cpuidle: haltpoll: Do not enable interrupts when entering idle	2024-01-25 15:35:15 -08:00
crypto	crypto: sahara - do not resize req->src when doing hash operations	2024-01-25 15:35:18 -08:00
cxl	cxl/port: Fix missing target list lock	2024-01-25 15:35:55 -08:00
dax
dca
devfreq	PM / devfreq: Fix buffer overflow in trans_stat_show	2024-01-31 16:18:50 -08:00
dio
dma	dmaengine: idxd: Move dma_free_coherent() out of spinlocked context	2024-01-31 16:18:47 -08:00
dma-buf	dma-buf: fix check in dma_resv_add_fence	2023-12-08 08:52:19 +01:00
edac	EDAC/thunderx: Fix possible out-of-bounds string access	2024-01-25 15:35:12 -08:00
eisa
extcon
firewire	firewire: ohci: suppress unexpected system reboot in AMD Ryzen machines and ASM108x/VT630x PCIe cards	2024-01-10 17:17:00 +01:00
firmware	firmware: ti_sci: Fix an off-by-one in ti_sci_debugfs_create()	2024-01-25 15:35:20 -08:00
fpga
fsi
gnss
gpio	gpio: mlxbf3: add an error code check in mlxbf3_gpio_probe	2024-01-25 15:35:58 -08:00
gpu	nouveau/vmm: don't set addr on the fail path to avoid warning	2024-01-31 16:18:56 -08:00
greybus
hid	HID: wacom: Correct behavior when processing some confidence == false touches	2024-01-25 15:35:48 -08:00
hsi
hte	hte: tegra: Fix missing error code in tegra_hte_test_probe()	2023-11-20 11:59:08 +01:00
hv
hwmon	hwmon: (corsair-psu) Fix probe when built-in	2024-01-20 11:51:42 +01:00
hwspinlock
hwtracing	coresight: etm4x: Fix width of CCITMIN field	2024-01-20 11:51:49 +01:00
i2c	i2c: s3c24xx: fix transferring more than one message in polling mode	2024-01-25 15:36:01 -08:00
i3c	i3c: master: svc: fix random hot join failure since timeout error	2023-11-28 17:20:06 +00:00
idle	x86: Fix CPUIDLE_FLAG_IRQ_ENABLE leaking timer reprogram	2024-01-25 15:35:12 -08:00
iio	iio: adc: ad7091r: Enable internal vref if external vref is not supplied	2024-01-31 16:18:47 -08:00
infiniband	IB/iser: Prevent invalidating wrong MR	2024-01-25 15:35:40 -08:00
input	Input: atkbd - use ab83 as id when skipping the getid command	2024-01-25 15:35:41 -08:00
interconnect	interconnect: qcom: sm8250: Enable sync_state	2024-01-01 12:42:36 +00:00
iommu	iommu: Don't reserve 0-length IOVA region	2024-01-25 15:35:54 -08:00
ipack
irqchip	irqchip/gic-v3-its: Flush ITS tables correctly in non-coherent GIC designs	2023-12-03 07:33:02 +01:00
isdn
leds	leds: aw200xx: Fix write to DIM parameter	2024-01-25 15:35:49 -08:00
macintosh
mailbox
mcb	mcb: fix error handling for different scenarios when parsing	2023-11-28 17:20:05 +00:00
md	Revert "Revert "md/raid5: Wait for MD_SB_CHANGE_PENDING in raid5d""	2024-01-25 15:36:01 -08:00
media	media: mtk-jpeg: Fix use after free bug due to error path handling in mtk_jpeg_dec_device_run	2024-01-31 16:18:55 -08:00
memory	memory: tegra: Set BPMP msg flags to reset IPC channels	2023-11-20 11:59:17 +01:00
memstick
message
mfd	mfd: intel-lpss: Fix the fractional clock divider flags	2024-01-25 15:35:49 -08:00
misc	misc: mei: client.c: fix problem of return '-EOVERFLOW' in mei_cl_write	2023-12-13 18:45:29 +01:00
mmc	mmc: mmc_spi: remove custom DMA mapped buffers	2024-01-31 16:18:55 -08:00
most
mtd	mtd: rawnand: Clarify conditions to enable continuous reads	2024-01-31 16:18:50 -08:00
mux
net	net: stmmac: Prevent DSA tags from breaking COE	2024-01-31 16:18:47 -08:00
nfc	nfc: virtual_ncidev: Add variable to check if ndev is running	2023-12-20 17:01:59 +01:00
ntb
nubus
nvdimm	nd_btt: Make BTT lanes preemptible	2023-11-20 11:59:19 +01:00
nvme	nvmet-tcp: Fix the H2C expected PDU len calculation	2024-01-25 15:35:55 -08:00
nvmem	nvmem: brcm_nvram: store a copy of NVRAM content	2024-01-01 12:42:44 +00:00
of	of: unittest: Fix of_count_phandle_with_args() expected value message	2024-01-25 15:35:40 -08:00
opp	OPP: Pass rounded rate to _set_opp()	2024-01-31 16:18:49 -08:00
parisc	parisc/power: Fix power soft-off button emulation on qemu	2024-01-31 16:18:52 -08:00
parport	parport: parport_serial: Add Brainboxes device IDs and geometry	2024-01-20 11:51:48 +01:00
pci	PCI: mediatek-gen3: Fix translation window size calculation	2024-01-25 15:35:55 -08:00
pcmcia	pcmcia: ds: fix possible name leak in error path in pcmcia_device_add()	2023-11-20 11:59:31 +01:00
peci
perf	drivers/perf: hisi: Fix some event id for HiSilicon UC pmu	2024-01-25 15:35:13 -08:00
phy	phy: sunplus: return negative error code in sp_usb_phy_probe	2024-01-10 17:16:57 +01:00
pinctrl	pinctrl: cy8c95x0: Fix get_pincfg	2024-01-20 11:51:46 +01:00
platform	platform/x86/intel/vsec: Fix xa_alloc memory leak	2024-01-25 15:35:14 -08:00
pmdomain	pmdomain: imx: Make imx pgc power domain also set the fwnode	2023-11-28 17:20:00 +00:00
pnp
power	power: supply: Fix null pointer dereference in smb2_probe	2024-01-25 15:35:54 -08:00
powercap	powercap: DTPM: Fix missing cpufreq_cpu_put() calls	2023-12-13 18:45:25 +01:00
pps
ps3
ptp	ptp: annotate data-race around q->head and q->tail	2023-11-28 17:19:51 +00:00
pwm	pwm: Fix out-of-bounds access in of_pwm_single_xlate()	2024-01-25 15:35:46 -08:00
rapidio
ras
regulator	regulator: qcom-rpmh: Fix smps4 regulator for pm8550ve	2023-11-20 11:59:07 +01:00
remoteproc
reset	reset: hisilicon: hi6220: fix Wvoid-pointer-to-enum-cast warning	2024-01-20 11:51:44 +01:00
rpmsg	rpmsg: virtio: Free driver_override when rpmsg_remove()	2024-01-31 16:18:50 -08:00
rtc	rtc: Extend timeout for waiting for UIP to clear to 1s	2024-01-31 16:18:56 -08:00
s390	s390/vfio-ap: do not reset queue removed from host config	2024-01-31 16:18:51 -08:00
sbus
scsi	scsi: core: Kick the requeue list after inserting when flushing	2024-01-31 16:18:48 -08:00
sh
siox
slimbus
soc	soc: fsl: cpm1: qmc: Fix rx channel reset	2024-01-31 16:18:51 -08:00
soundwire	soundwire: fix initializing sysfs for same devices on different buses	2024-01-31 16:18:47 -08:00
spi	spi: coldfire-qspi: Remove an erroneous clk_disable_unprepare() from the remove function	2024-01-25 15:35:55 -08:00
spmi	spmi: mtk-pmif: Serialize PMIF status check and command submission	2024-01-25 15:35:53 -08:00
ssb
staging	media: rkvdec: Hook the (TRY_)DECODER_CMD stateless ioctls	2024-01-25 15:35:32 -08:00
target	scsi: target: core: add missing file_{start,end}_write()	2024-01-25 15:35:45 -08:00
tc
tee	tee: optee: Fix supplicant based device enumeration	2023-12-13 18:45:11 +01:00
thermal	drivers/thermal/loongson2_thermal: Fix incorrect PTR_ERR() judgment	2024-01-25 15:35:15 -08:00
thunderbolt	thunderbolt: Fix memory leak in margining_port_remove()	2024-01-01 12:42:46 +00:00
tty	serial: core: set missing supported flag for RX during TX GPIO	2024-01-31 16:18:47 -08:00
ufs	scsi: ufs: core: Remove the ufshcd_hba_exit() call from ufshcd_async_scan()	2024-01-31 16:18:48 -08:00
uio	uio: Fix use-after-free in uio_open	2024-01-20 11:51:48 +01:00
usb	usb: xhci-mtk: fix a short packet issue of gen1 isoc-in transfer	2024-01-25 15:35:54 -08:00
vdpa	vdpa: Fix an error handling path in eni_vdpa_probe()	2024-01-25 15:35:54 -08:00
vfio	hisi_acc_vfio_pci: Update migration data pointer correctly on saving/resume	2024-01-25 15:35:55 -08:00
vhost	virtio/vsock: send credit update during setting SO_RCVLOWAT	2024-01-25 15:35:26 -08:00
video	fbdev: flush deferred IO before closing	2024-01-25 15:35:45 -08:00
virt	virt: sevguest: Fix passing a stack buffer as a scatterlist target	2023-11-20 11:59:30 +01:00
virtio	virtio_ring: fix syncs DMA memory with different direction	2024-01-05 15:19:41 +01:00
vlynq
w1
watchdog	watchdog: rti_wdt: Drop runtime pm reference count when watchdog is unused	2024-01-25 15:35:37 -08:00
xen	swiotlb-xen: provide the "max_mapping_size" method	2023-12-03 07:33:07 +01:00
zorro
Kconfig
Makefile