MIRRORS/linux-yocto
1
0
Fork 0
mirror of git://git.yoctoproject.org/linux-yocto.git synced 2025-07-05 13:25:20 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

mfd: tps65912: Use devm helper functions to simplify probe

Browse Source 
This simplifies probe and also allows us to remove the remove
callbacks from the core and interface drivers. Do that here.

Signed-off-by: Andrew Davis <afd@ti.com>
Link: https://lore.kernel.org/r/20240613175430.57698-1-afd@ti.com
Signed-off-by: Lee Jones <lee@kernel.org>
This commit is contained in:
Andrew Davis 2024-06-13 12:54:30 -05:00 committed by Lee Jones
parent 0ddabc8c6e
commit 13c151a919
4 changed files with 7 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
drivers/mfd/tps65912-core.c
View File

@ -90,29 +90,22 @@ int tps65912_device_init(struct tps65912 *tps)
{ {
int ret; int ret;
ret = regmap_add_irq_chip(tps->regmap, tps->irq, IRQF_ONESHOT, 0, ret = devm_regmap_add_irq_chip(tps->dev, tps->regmap, tps->irq,
&tps65912_irq_chip, &tps->irq_data); IRQF_ONESHOT, 0, &tps65912_irq_chip,
&tps->irq_data);
if (ret) if (ret)
return ret; return ret;
ret = mfd_add_devices(tps->dev, PLATFORM_DEVID_AUTO, tps65912_cells, ret = devm_mfd_add_devices(tps->dev, PLATFORM_DEVID_AUTO, tps65912_cells,
ARRAY_SIZE(tps65912_cells), NULL, 0, ARRAY_SIZE(tps65912_cells), NULL, 0,
regmap_irq_get_domain(tps->irq_data)); regmap_irq_get_domain(tps->irq_data));
if (ret) { if (ret)
regmap_del_irq_chip(tps->irq, tps->irq_data);
return ret; return ret;
}
return 0; return 0;
} }
EXPORT_SYMBOL_GPL(tps65912_device_init); EXPORT_SYMBOL_GPL(tps65912_device_init);
void tps65912_device_exit(struct tps65912 *tps)
{
regmap_del_irq_chip(tps->irq, tps->irq_data);
}
EXPORT_SYMBOL_GPL(tps65912_device_exit);
MODULE_AUTHOR("Andrew F. Davis <afd@ti.com>"); MODULE_AUTHOR("Andrew F. Davis <afd@ti.com>");
MODULE_DESCRIPTION("TPS65912x MFD Driver"); MODULE_DESCRIPTION("TPS65912x MFD Driver");
MODULE_LICENSE("GPL v2"); MODULE_LICENSE("GPL v2");

8
drivers/mfd/tps65912-i2c.c
View File

@ -42,13 +42,6 @@ static int tps65912_i2c_probe(struct i2c_client *client)
return tps65912_device_init(tps); return tps65912_device_init(tps);
} }
static void tps65912_i2c_remove(struct i2c_client *client)
{
struct tps65912 *tps = i2c_get_clientdata(client);
tps65912_device_exit(tps);
}
static const struct i2c_device_id tps65912_i2c_id_table[] = { static const struct i2c_device_id tps65912_i2c_id_table[] = {
{ "tps65912" }, { "tps65912" },
{ /* sentinel */ } { /* sentinel */ }
@ -61,7 +54,6 @@ static struct i2c_driver tps65912_i2c_driver = {
.of_match_table = tps65912_i2c_of_match_table, .of_match_table = tps65912_i2c_of_match_table,
}, },
.probe = tps65912_i2c_probe, .probe = tps65912_i2c_probe,
.remove = tps65912_i2c_remove,
.id_table = tps65912_i2c_id_table, .id_table = tps65912_i2c_id_table,
}; };
module_i2c_driver(tps65912_i2c_driver); module_i2c_driver(tps65912_i2c_driver);

8
drivers/mfd/tps65912-spi.c
View File

@ -42,13 +42,6 @@ static int tps65912_spi_probe(struct spi_device *spi)
return tps65912_device_init(tps); return tps65912_device_init(tps);
} }
static void tps65912_spi_remove(struct spi_device *spi)
{
struct tps65912 *tps = spi_get_drvdata(spi);
tps65912_device_exit(tps);
}
static const struct spi_device_id tps65912_spi_id_table[] = { static const struct spi_device_id tps65912_spi_id_table[] = {
{ "tps65912", 0 }, { "tps65912", 0 },
{ /* sentinel */ } { /* sentinel */ }
@ -61,7 +54,6 @@ static struct spi_driver tps65912_spi_driver = {
.of_match_table = tps65912_spi_of_match_table, .of_match_table = tps65912_spi_of_match_table,
}, },
.probe = tps65912_spi_probe, .probe = tps65912_spi_probe,
.remove = tps65912_spi_remove,
.id_table = tps65912_spi_id_table, .id_table = tps65912_spi_id_table,
}; };
module_spi_driver(tps65912_spi_driver); module_spi_driver(tps65912_spi_driver);

1
include/linux/mfd/tps65912.h
View File

@ -314,6 +314,5 @@ struct tps65912 {
extern const struct regmap_config tps65912_regmap_config; extern const struct regmap_config tps65912_regmap_config;
int tps65912_device_init(struct tps65912 *tps); int tps65912_device_init(struct tps65912 *tps);
void tps65912_device_exit(struct tps65912 *tps);
#endif /* __LINUX_MFD_TPS65912_H */ #endif /* __LINUX_MFD_TPS65912_H */