MIRRORS/linux-yocto
1
0
Fork 0
mirror of git://git.yoctoproject.org/linux-yocto.git synced 2025-10-22 23:13:01 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

misc: amd-sbi: Explicitly clear in/out arg "mb_in_out"

Browse Source 
- New AMD processor will support different input/output for same command.
- In some scenarios the input value is not cleared, which will be added to
  output before reporting the data.
- Clearing input explicitly will be a cleaner and safer approach.

Reviewed-by: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@amd.com>
Signed-off-by: Akshay Gupta <akshay.gupta@amd.com>
Link: https://lore.kernel.org/r/20250716110729.2193725-3-akshay.gupta@amd.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Akshay Gupta 2025-07-16 11:07:29 +00:00 committed by Greg Kroah-Hartman
parent bbb4013947
commit 16ad3ee51f
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/misc/amd-sbi/rmi-core.c
View File

@ -320,6 +320,10 @@ int rmi_mailbox_xfer(struct sbrmi_data *data,
ret = regmap_read(data->regmap, SBRMI_OUTBNDMSG7, &ec); ret = regmap_read(data->regmap, SBRMI_OUTBNDMSG7, &ec);
if (ret || ec) if (ret || ec)
goto exit_clear_alert; goto exit_clear_alert;
/* Clear the input value before updating the output data */
msg->mb_in_out = 0;
/* /*
* For a read operation, the initiator (BMC) reads the firmware * For a read operation, the initiator (BMC) reads the firmware
* response Command Data Out[31:0] from SBRMI::OutBndMsg_inst[4:1] * response Command Data Out[31:0] from SBRMI::OutBndMsg_inst[4:1]