mirror of
git://git.yoctoproject.org/linux-yocto.git
synced 2025-10-22 15:03:53 +02:00
iomap: avoid unnecessary ifs_set_range_uptodate() with locks
In the buffer write path, iomap_set_range_uptodate() is called every time iomap_end_write() is called. But if folio_test_uptodate() holds, we know that all blocks in this folio are already in the uptodate state, so there is no need to go deep into the critical section of state_lock to execute bitmap_set(). This is because the folios always creep towards ifs_is_fully_uptodate() state and once they've gotten there folio_mark_uptodate() is called, which means the folio is uptodate. Then once a folio is uptodate, there is no route back to !uptodate without going through the removal of the folio from the page cache. Therefore, it's fine to use folio_test_uptodate() to short-circuit unnecessary code paths. Although state_lock may not have significant lock contention due to folio lock, this patch at least reduces the number of instructions, especially the expensive lock-prefixed instructions. Signed-off-by: Jinliang Zheng <alexjlzheng@tencent.com> Link: https://lore.kernel.org/20250711081207.1782667-1-alexjlzheng@tencent.com Reviewed-by: Darrick J. Wong <djwong@kernel.org> Reviewed-by: Christoph Hellwig <hch@infradead.org> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Christian Brauner <brauner@kernel.org>
This commit is contained in:
parent
0a9e740513
commit
177bb4cba9
|
@ -71,6 +71,9 @@ static void iomap_set_range_uptodate(struct folio *folio, size_t off,
|
|||
unsigned long flags;
|
||||
bool uptodate = true;
|
||||
|
||||
if (folio_test_uptodate(folio))
|
||||
return;
|
||||
|
||||
if (ifs) {
|
||||
spin_lock_irqsave(&ifs->state_lock, flags);
|
||||
uptodate = ifs_set_range_uptodate(folio, ifs, off, len);
|
||||
|
|
Loading…
Reference in New Issue
Block a user