mirror of
git://git.yoctoproject.org/linux-yocto.git
synced 2025-10-22 23:13:01 +02:00
media: i2c: imx412: Add missing newline to prints
Add trailing \n to dev_dbg and dev_err prints where missing.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Fixes: 9214e86c0c
("media: i2c: Add imx412 camera sensor driver")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
parent
c699b6c7c8
commit
33f4a7fba7
|
@ -547,7 +547,7 @@ static int imx412_update_exp_gain(struct imx412 *imx412, u32 exposure, u32 gain)
|
|||
|
||||
lpfr = imx412->vblank + imx412->cur_mode->height;
|
||||
|
||||
dev_dbg(imx412->dev, "Set exp %u, analog gain %u, lpfr %u",
|
||||
dev_dbg(imx412->dev, "Set exp %u, analog gain %u, lpfr %u\n",
|
||||
exposure, gain, lpfr);
|
||||
|
||||
ret = imx412_write_reg(imx412, IMX412_REG_HOLD, 1, 1);
|
||||
|
@ -594,7 +594,7 @@ static int imx412_set_ctrl(struct v4l2_ctrl *ctrl)
|
|||
case V4L2_CID_VBLANK:
|
||||
imx412->vblank = imx412->vblank_ctrl->val;
|
||||
|
||||
dev_dbg(imx412->dev, "Received vblank %u, new lpfr %u",
|
||||
dev_dbg(imx412->dev, "Received vblank %u, new lpfr %u\n",
|
||||
imx412->vblank,
|
||||
imx412->vblank + imx412->cur_mode->height);
|
||||
|
||||
|
@ -613,7 +613,7 @@ static int imx412_set_ctrl(struct v4l2_ctrl *ctrl)
|
|||
exposure = ctrl->val;
|
||||
analog_gain = imx412->again_ctrl->val;
|
||||
|
||||
dev_dbg(imx412->dev, "Received exp %u, analog gain %u",
|
||||
dev_dbg(imx412->dev, "Received exp %u, analog gain %u\n",
|
||||
exposure, analog_gain);
|
||||
|
||||
ret = imx412_update_exp_gain(imx412, exposure, analog_gain);
|
||||
|
@ -622,7 +622,7 @@ static int imx412_set_ctrl(struct v4l2_ctrl *ctrl)
|
|||
|
||||
break;
|
||||
default:
|
||||
dev_err(imx412->dev, "Invalid control %d", ctrl->id);
|
||||
dev_err(imx412->dev, "Invalid control %d\n", ctrl->id);
|
||||
ret = -EINVAL;
|
||||
}
|
||||
|
||||
|
@ -803,14 +803,14 @@ static int imx412_start_streaming(struct imx412 *imx412)
|
|||
ret = imx412_write_regs(imx412, reg_list->regs,
|
||||
reg_list->num_of_regs);
|
||||
if (ret) {
|
||||
dev_err(imx412->dev, "fail to write initial registers");
|
||||
dev_err(imx412->dev, "fail to write initial registers\n");
|
||||
return ret;
|
||||
}
|
||||
|
||||
/* Setup handler will write actual exposure and gain */
|
||||
ret = __v4l2_ctrl_handler_setup(imx412->sd.ctrl_handler);
|
||||
if (ret) {
|
||||
dev_err(imx412->dev, "fail to setup handler");
|
||||
dev_err(imx412->dev, "fail to setup handler\n");
|
||||
return ret;
|
||||
}
|
||||
|
||||
|
@ -821,7 +821,7 @@ static int imx412_start_streaming(struct imx412 *imx412)
|
|||
ret = imx412_write_reg(imx412, IMX412_REG_MODE_SELECT,
|
||||
1, IMX412_MODE_STREAMING);
|
||||
if (ret) {
|
||||
dev_err(imx412->dev, "fail to start streaming");
|
||||
dev_err(imx412->dev, "fail to start streaming\n");
|
||||
return ret;
|
||||
}
|
||||
|
||||
|
@ -895,7 +895,7 @@ static int imx412_detect(struct imx412 *imx412)
|
|||
return ret;
|
||||
|
||||
if (val != IMX412_ID) {
|
||||
dev_err(imx412->dev, "chip id mismatch: %x!=%x",
|
||||
dev_err(imx412->dev, "chip id mismatch: %x!=%x\n",
|
||||
IMX412_ID, val);
|
||||
return -ENXIO;
|
||||
}
|
||||
|
@ -927,7 +927,7 @@ static int imx412_parse_hw_config(struct imx412 *imx412)
|
|||
imx412->reset_gpio = devm_gpiod_get_optional(imx412->dev, "reset",
|
||||
GPIOD_OUT_LOW);
|
||||
if (IS_ERR(imx412->reset_gpio)) {
|
||||
dev_err(imx412->dev, "failed to get reset gpio %ld",
|
||||
dev_err(imx412->dev, "failed to get reset gpio %ld\n",
|
||||
PTR_ERR(imx412->reset_gpio));
|
||||
return PTR_ERR(imx412->reset_gpio);
|
||||
}
|
||||
|
@ -935,13 +935,13 @@ static int imx412_parse_hw_config(struct imx412 *imx412)
|
|||
/* Get sensor input clock */
|
||||
imx412->inclk = devm_clk_get(imx412->dev, NULL);
|
||||
if (IS_ERR(imx412->inclk)) {
|
||||
dev_err(imx412->dev, "could not get inclk");
|
||||
dev_err(imx412->dev, "could not get inclk\n");
|
||||
return PTR_ERR(imx412->inclk);
|
||||
}
|
||||
|
||||
rate = clk_get_rate(imx412->inclk);
|
||||
if (rate != IMX412_INCLK_RATE) {
|
||||
dev_err(imx412->dev, "inclk frequency mismatch");
|
||||
dev_err(imx412->dev, "inclk frequency mismatch\n");
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
|
@ -966,14 +966,14 @@ static int imx412_parse_hw_config(struct imx412 *imx412)
|
|||
|
||||
if (bus_cfg.bus.mipi_csi2.num_data_lanes != IMX412_NUM_DATA_LANES) {
|
||||
dev_err(imx412->dev,
|
||||
"number of CSI2 data lanes %d is not supported",
|
||||
"number of CSI2 data lanes %d is not supported\n",
|
||||
bus_cfg.bus.mipi_csi2.num_data_lanes);
|
||||
ret = -EINVAL;
|
||||
goto done_endpoint_free;
|
||||
}
|
||||
|
||||
if (!bus_cfg.nr_of_link_frequencies) {
|
||||
dev_err(imx412->dev, "no link frequencies defined");
|
||||
dev_err(imx412->dev, "no link frequencies defined\n");
|
||||
ret = -EINVAL;
|
||||
goto done_endpoint_free;
|
||||
}
|
||||
|
@ -1034,7 +1034,7 @@ static int imx412_power_on(struct device *dev)
|
|||
|
||||
ret = clk_prepare_enable(imx412->inclk);
|
||||
if (ret) {
|
||||
dev_err(imx412->dev, "fail to enable inclk");
|
||||
dev_err(imx412->dev, "fail to enable inclk\n");
|
||||
goto error_reset;
|
||||
}
|
||||
|
||||
|
@ -1145,7 +1145,7 @@ static int imx412_init_controls(struct imx412 *imx412)
|
|||
imx412->hblank_ctrl->flags |= V4L2_CTRL_FLAG_READ_ONLY;
|
||||
|
||||
if (ctrl_hdlr->error) {
|
||||
dev_err(imx412->dev, "control init failed: %d",
|
||||
dev_err(imx412->dev, "control init failed: %d\n",
|
||||
ctrl_hdlr->error);
|
||||
v4l2_ctrl_handler_free(ctrl_hdlr);
|
||||
return ctrl_hdlr->error;
|
||||
|
@ -1183,7 +1183,7 @@ static int imx412_probe(struct i2c_client *client)
|
|||
|
||||
ret = imx412_parse_hw_config(imx412);
|
||||
if (ret) {
|
||||
dev_err(imx412->dev, "HW configuration is not supported");
|
||||
dev_err(imx412->dev, "HW configuration is not supported\n");
|
||||
return ret;
|
||||
}
|
||||
|
||||
|
@ -1191,14 +1191,14 @@ static int imx412_probe(struct i2c_client *client)
|
|||
|
||||
ret = imx412_power_on(imx412->dev);
|
||||
if (ret) {
|
||||
dev_err(imx412->dev, "failed to power-on the sensor");
|
||||
dev_err(imx412->dev, "failed to power-on the sensor\n");
|
||||
goto error_mutex_destroy;
|
||||
}
|
||||
|
||||
/* Check module identity */
|
||||
ret = imx412_detect(imx412);
|
||||
if (ret) {
|
||||
dev_err(imx412->dev, "failed to find sensor: %d", ret);
|
||||
dev_err(imx412->dev, "failed to find sensor: %d\n", ret);
|
||||
goto error_power_off;
|
||||
}
|
||||
|
||||
|
@ -1208,7 +1208,7 @@ static int imx412_probe(struct i2c_client *client)
|
|||
|
||||
ret = imx412_init_controls(imx412);
|
||||
if (ret) {
|
||||
dev_err(imx412->dev, "failed to init controls: %d", ret);
|
||||
dev_err(imx412->dev, "failed to init controls: %d\n", ret);
|
||||
goto error_power_off;
|
||||
}
|
||||
|
||||
|
@ -1222,14 +1222,14 @@ static int imx412_probe(struct i2c_client *client)
|
|||
imx412->pad.flags = MEDIA_PAD_FL_SOURCE;
|
||||
ret = media_entity_pads_init(&imx412->sd.entity, 1, &imx412->pad);
|
||||
if (ret) {
|
||||
dev_err(imx412->dev, "failed to init entity pads: %d", ret);
|
||||
dev_err(imx412->dev, "failed to init entity pads: %d\n", ret);
|
||||
goto error_handler_free;
|
||||
}
|
||||
|
||||
ret = v4l2_async_register_subdev_sensor(&imx412->sd);
|
||||
if (ret < 0) {
|
||||
dev_err(imx412->dev,
|
||||
"failed to register async subdev: %d", ret);
|
||||
"failed to register async subdev: %d\n", ret);
|
||||
goto error_media_entity;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue
Block a user